[resend] drm/i915: Add support for dual-channel LVDS on 8xx.
diff mbox

Message ID 20090819222843.0a3bce4e@neptune.home
State Accepted
Headers show

Commit Message

Bruno Prémont Aug. 19, 2009, 8:28 p.m. UTC
drm/i915: Check if BIOS enabled dual-channel LVDS on 8xx, not only on 9xx

Commit 0c2e39525b3b53a97a0202c5f35058147e53977e is not sufficient to
get fd.o bug #20115 fixed.
In addition intel_find_best_PLL() must not only rely on BIOS settings
for i9xx chips but also for i8xx, so drop the IS_I9XX() check.

Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
--
Hi Eric, Ma Ling,

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=0c2e39525b3b53a97a0202c5f35058147e53977e
(drm/i915: Add support for dual-channel LVDS on 8xx.) is not sufficient
for i8xx, below patch is needed too for LVDS to work on my Acer TM66x.

In case this is not appropriate for newer chips replacing IS_I9XX(dev)
with (IS_I9XX(dev) || IS_I85X(dev)) would be sufficient for me though
other i8xx variants would possibly need to be added too/later on.

Bruno
--
 		   current

Comments

Zhao, Yakui Aug. 24, 2009, 5:14 a.m. UTC | #1
On Thu, 2009-08-20 at 04:28 +0800, Bruno Prémont wrote:
> drm/i915: Check if BIOS enabled dual-channel LVDS on 8xx, not only on 9xx
> 
> Commit 0c2e39525b3b53a97a0202c5f35058147e53977e is not sufficient to
> get fd.o bug #20115 fixed.
> In addition intel_find_best_PLL() must not only rely on BIOS settings
> for i9xx chips but also for i8xx, so drop the IS_I9XX() check.
> 
> Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
Agree. We should also check whether the dual-channel is enabled on the
8xx platform.

Acked-by: Zhao Yakui <yakui.zhao@intel.com>
> --
> Hi Eric, Ma Ling,
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=0c2e39525b3b53a97a0202c5f35058147e53977e
> (drm/i915: Add support for dual-channel LVDS on 8xx.) is not sufficient
> for i8xx, below patch is needed too for LVDS to work on my Acer TM66x.
> 
> In case this is not appropriate for newer chips replacing IS_I9XX(dev)
> with (IS_I9XX(dev) || IS_I85X(dev)) would be sufficient for me though
> other i8xx variants would possibly need to be added too/later on.
> 
> Bruno
> --
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index d6fce21..486bdaf 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -666,7 +666,7 @@ intel_find_best_PLL(const intel_limit_t *limit, struct drm_crtc *crtc,
>  	intel_clock_t clock;
>  	int err = target;
>  
> -	if (IS_I9XX(dev) && intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) &&
> +	if (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) &&
>  	    (I915_READ(LVDS)) != 0) {
>  		/*
>  		 * For LVDS, if the panel is on, just rely on its
>  		   current
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patch
diff mbox

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index d6fce21..486bdaf 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -666,7 +666,7 @@  intel_find_best_PLL(const intel_limit_t *limit, struct drm_crtc *crtc,
 	intel_clock_t clock;
 	int err = target;
 
-	if (IS_I9XX(dev) && intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) &&
+	if (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) &&
 	    (I915_READ(LVDS)) != 0) {
 		/*
 		 * For LVDS, if the panel is on, just rely on its