ASoC: intel: The Baytrail/MAX98090 driver depends on I2C
diff mbox

Message ID 1401650018-31023-1-git-send-email-broonie@kernel.org
State Accepted
Commit d8188f00e7f57412b5bb4405f636cb7c3d8f42a6
Headers show

Commit Message

Mark Brown June 1, 2014, 7:13 p.m. UTC
From: Mark Brown <broonie@linaro.org>

Signed-off-by: Mark Brown <broonie@linaro.org>
---
 sound/soc/intel/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kevin Strasser June 2, 2014, 1:30 a.m. UTC | #1
Hi Mark,

> From: Mark Brown <broonie@linaro.org>
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>  sound/soc/intel/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index cd3498736e91..c30fedb3e149 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -52,7 +52,7 @@ config SND_SOC_INTEL_BYT_RT5640_MACH
>
>  config SND_SOC_INTEL_BYT_MAX98090_MACH
>  	tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec"
> -	depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS
> +	depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS && I2C

I think the dependency on I2C is specific to the MAX98090 codec.
Can we add this to the codec config entry instead?

Thanks,
Kevin

>  	select SND_SOC_INTEL_BAYTRAIL
>  	select SND_SOC_MAX98090
>  	help
> --
> 2.0.0.rc4
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
Mark Brown June 2, 2014, 9:40 a.m. UTC | #2
On Sun, Jun 01, 2014 at 06:30:03PM -0700, kevin.strasser@linux.intel.com wrote:

> >  	tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec"
> > -	depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS
> > +	depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS && I2C

> I think the dependency on I2C is specific to the MAX98090 codec.
> Can we add this to the codec config entry instead?

No, selects ignore dependencies.

Patch
diff mbox

diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index cd3498736e91..c30fedb3e149 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -52,7 +52,7 @@  config SND_SOC_INTEL_BYT_RT5640_MACH
 
 config SND_SOC_INTEL_BYT_MAX98090_MACH
 	tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec"
-	depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS
+	depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS && I2C
 	select SND_SOC_INTEL_BAYTRAIL
 	select SND_SOC_MAX98090
 	help