Patchwork ipv4: make ip_append_data() handle NULL routing table

login
register
mail settings
Submitter Julien TINNES
Date Aug. 27, 2009, 1:26 p.m.
Message ID <20090827132658.GA17099@cr0.org>
Download mbox | patch
Permalink /patch/44268/
State New, archived
Headers show

Comments

Julien TINNES - Aug. 27, 2009, 1:26 p.m.
Add a check in ip_append_data() for NULL *rtp to prevent future bugs in callers from being exploitable.

Signed-off-by: Julien Tinnes <julien@cr0.org>
Signed-off-by: Tavis Ormandy <taviso@sdf.lonestar.org>
Acked-by: David S. Miller <davem@davemloft.net>

---

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch

diff -r b3cbf0ceeb34 net/ipv4/ip_output.c
--- a/net/ipv4/ip_output.c	Mon Aug 24 14:48:29 2009 +0200
+++ b/net/ipv4/ip_output.c	Thu Aug 27 15:20:36 2009 +0200
@@ -814,6 +814,8 @@ 
 			inet->cork.addr = ipc->addr;
 		}
 		rt = *rtp;
+		if (unlikely(!rt))
+			return -EFAULT;
 		/*
 		 * We steal reference to this route, caller should not release it
 		 */