[V2] ASoC: mcbsp: remove unnecessary null test before kfree
diff mbox

Message ID 1403812063-12251-1-git-send-email-fabf@skynet.be
State New, archived
Headers show

Commit Message

Fabian Frederick June 26, 2014, 7:47 p.m. UTC
Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
V2: replace subject "sound/soc/omap/mcbsp.c" by "ASoC: mcbsp:"
(suggested by Peter Ujfalusi)

 sound/soc/omap/mcbsp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Jarkko Nikula June 27, 2014, 6:01 a.m. UTC | #1
On Thu, Jun 26, 2014 at 09:47:43PM +0200, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
> 
> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> V2: replace subject "sound/soc/omap/mcbsp.c" by "ASoC: mcbsp:"
> (suggested by Peter Ujfalusi)
> 
>  sound/soc/omap/mcbsp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
I noticed ASoC maintainers Mark Brown <broonie@kernel.org> and Liam
Girdwood <lgirdwood@gmail.com> were not CC'ed so in case this patch gets buried
under list traffic and if you won't see this patch applied in a ~1 week, please
resend with them CC'ed.

Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>

Patch
diff mbox

diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
index 86c7538..68a1252 100644
--- a/sound/soc/omap/mcbsp.c
+++ b/sound/soc/omap/mcbsp.c
@@ -621,8 +621,7 @@  void omap_mcbsp_free(struct omap_mcbsp *mcbsp)
 	mcbsp->reg_cache = NULL;
 	spin_unlock(&mcbsp->lock);
 
-	if (reg_cache)
-		kfree(reg_cache);
+	kfree(reg_cache);
 }
 
 /*