diff mbox

[Bug,79051] New: Panic with radeon hd 5750, bisected

Message ID bug-79051-2300@https.bugzilla.kernel.org/ (mailing list archive)
State New, archived
Headers show

Commit Message

bugzilla-daemon@bugzilla.kernel.org June 27, 2014, 12:52 p.m. UTC
https://bugzilla.kernel.org/show_bug.cgi?id=79051

            Bug ID: 79051
           Summary: Panic with radeon hd 5750, bisected
           Product: Drivers
           Version: 2.5
    Kernel Version: 3.14.6 - 3.16-rc2
          Hardware: x86-64
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Video(DRI - non Intel)
          Assignee: drivers_video-dri@kernel-bugs.osdl.org
          Reporter: jonathan@unbiased.name
        Regression: No

Happens usually within first minute of starting weston (drm on archlinux.) just
opening windows and moving mouse. (no panic within X.)

Bisected to
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?h=linux-3.14.y&id=19aef29eea6e5b42e4097c2ccdd80e944e9f9f6f

Still same with 3.16-rc2.

Panic only dumped to screen so don't have exact copy.
RIP in drm_vblank_put
radeon_crt_handle_flip
evergreen_irq_process
notice_schd_clock
radeon_irq_handler_kms
handle_irq_events_percpu
...

Removing the one line stops the panic so does this;

                        switch (src_data) {

Only guess work on my part. Needs someone with knowledge of code determine real
fix.

Comments

bugzilla-daemon@bugzilla.kernel.org June 27, 2014, 9:06 p.m. UTC | #1
https://bugzilla.kernel.org/show_bug.cgi?id=79051

Alex Deucher <alexdeucher@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexdeucher@gmail.com

--- Comment #1 from Alex Deucher <alexdeucher@gmail.com> ---
See this patch set and discussion:
http://lists.freedesktop.org/archives/dri-devel/2014-June/062411.html
bugzilla-daemon@bugzilla.kernel.org June 28, 2014, 2:02 p.m. UTC | #2
https://bugzilla.kernel.org/show_bug.cgi?id=79051

--- Comment #2 from Ed Tomlinson <edt@aei.ca> ---
I am seeing a similar panic on a R7 260X.

See:
https://plus.google.com/u/0/photos/108244876431105742323/albums/6029631260384977873/6029631269719723986?pid=6029631269719723986&oid=108244876431105742323

I cannot reproduce this on demand.  I am currently trying patch #2 and will
report if I see impossible msc times.
bugzilla-daemon@bugzilla.kernel.org July 11, 2014, 4:32 p.m. UTC | #3
https://bugzilla.kernel.org/show_bug.cgi?id=79051

Jonathan Howard <jonathan@unbiased.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |PATCH_ALREADY_AVAILABLE

--- Comment #3 from Jonathan Howard <jonathan@unbiased.name> ---
3.16-rc4 3.15.5 both working. Expect (unchecked) discussion (above) patch is
applied.
diff mbox

Patch

diff --git a/drivers/gpu/drm/radeon/evergreen.c
b/drivers/gpu/drm/radeon/evergre
index 971d933..e31d936 100644
--- a/drivers/gpu/drm/radeon/evergreen.c
+++ b/drivers/gpu/drm/radeon/evergreen.c
@@ -4967,7 +4967,8 @@  restart_ih:
                case 16: /* D5 page flip */
                case 18: /* D6 page flip */
                        DRM_DEBUG("IH: D%d flip\n", ((src_id - 8) >> 1) + 1);
-                       radeon_crtc_handle_flip(rdev, (src_id - 8) >> 1);
+                       if (atomic_read(&rdev->irq.pflip[(src_id - 8) >> 1]))
+                               radeon_crtc_handle_flip(rdev, (src_id - 8) >>
1)
                        break;
                case 42: /* HPD hotplug */