| Message ID | 1404452861-8951-1-git-send-email-vinod.koul@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0a37c6efec4a2fdc2563c5a8faa472b814deee80 |
| Headers | show |
On Fri, Jul 04, 2014 at 11:17:41AM +0530, Vinod Koul wrote: > From: Praveen Diwakar <praveen.diwakar@intel.com> > > Since MODULE_LICENSE is missing the module load fails, > so add this for module. Always CC maintainers on patches (in this case the Wolfson people), especially for something like licensing. > Signed-off-by: Praveen Diwakar <praveen.diwakar@intel.com> > Signed-off-by: Vinod Koul <vinod.koul@intel.com> > --- > --- > sound/soc/codecs/wm_adsp.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c > index 0600271..2537725 100644 > --- a/sound/soc/codecs/wm_adsp.c > +++ b/sound/soc/codecs/wm_adsp.c > @@ -1758,3 +1758,5 @@ int wm_adsp2_init(struct wm_adsp *adsp, bool dvfs) > return 0; > } > EXPORT_SYMBOL_GPL(wm_adsp2_init); > + > +MODULE_LICENSE("GPL v2"); > -- > 1.7.0.4 > >
On Fri, Jul 04, 2014 at 12:47:23PM +0100, Mark Brown wrote: > On Fri, Jul 04, 2014 at 11:17:41AM +0530, Vinod Koul wrote: > > From: Praveen Diwakar <praveen.diwakar@intel.com> > > > > Since MODULE_LICENSE is missing the module load fails, > > so add this for module. > > Always CC maintainers on patches (in this case the Wolfson people), > especially for something like licensing. Indeed we would definitely like to be in the loop on licensing changes :-) > > > Signed-off-by: Praveen Diwakar <praveen.diwakar@intel.com> > > Signed-off-by: Vinod Koul <vinod.koul@intel.com> > > --- > > --- > > sound/soc/codecs/wm_adsp.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c > > index 0600271..2537725 100644 > > --- a/sound/soc/codecs/wm_adsp.c > > +++ b/sound/soc/codecs/wm_adsp.c > > @@ -1758,3 +1758,5 @@ int wm_adsp2_init(struct wm_adsp *adsp, bool dvfs) > > return 0; > > } > > EXPORT_SYMBOL_GPL(wm_adsp2_init); > > + > > +MODULE_LICENSE("GPL v2"); Yeah this is fine, I have been meaning to do that myself. Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Thanks, Charles
On Fri, Jul 04, 2014 at 11:17:41AM +0530, Vinod Koul wrote: > From: Praveen Diwakar <praveen.diwakar@intel.com> > > Since MODULE_LICENSE is missing the module load fails, > so add this for module. Applied, thanks.
On Fri, Jul 04, 2014 at 01:47:24PM +0100, Charles Keepax wrote: > On Fri, Jul 04, 2014 at 12:47:23PM +0100, Mark Brown wrote: > > On Fri, Jul 04, 2014 at 11:17:41AM +0530, Vinod Koul wrote: > > > From: Praveen Diwakar <praveen.diwakar@intel.com> > > > > > > Since MODULE_LICENSE is missing the module load fails, > > > so add this for module. > > > > Always CC maintainers on patches (in this case the Wolfson people), > > especially for something like licensing. > > Indeed we would definitely like to be in the loop on licensing > changes :-) Sorry about missing you folks on this. Somehow still mind equated wm with Mark. We should let get_maintainers do this, always :)
diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c index 0600271..2537725 100644 --- a/sound/soc/codecs/wm_adsp.c +++ b/sound/soc/codecs/wm_adsp.c @@ -1758,3 +1758,5 @@ int wm_adsp2_init(struct wm_adsp *adsp, bool dvfs) return 0; } EXPORT_SYMBOL_GPL(wm_adsp2_init); + +MODULE_LICENSE("GPL v2");