| Message ID | 1405954467-29331-1-git-send-email-wens@csie.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jul 21, 2014 at 10:54:27PM +0800, Chen-Yu Tsai wrote: > dtc was giving warnings for missing #address-cells and #size-cells for > the new sun6i-a31-hummingbird.dts, which has a i2c-based rtc device. > > This patch adds the properties for all i2c controller nodes for sun6i. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Applied, thanks. I don't plan on sending more DT pull-request unless something big shows up, so it's probably queued for 3.18. It's not like it's urgent anyway... Maxime
On Monday 28 July 2014 11:35:32 Maxime Ripard wrote: > On Mon, Jul 21, 2014 at 10:54:27PM +0800, Chen-Yu Tsai wrote: > > dtc was giving warnings for missing #address-cells and #size-cells for > > the new sun6i-a31-hummingbird.dts, which has a i2c-based rtc device. > > > > This patch adds the properties for all i2c controller nodes for sun6i. > > > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > Applied, thanks. > > I don't plan on sending more DT pull-request unless something big > shows up, so it's probably queued for 3.18. > > It's not like it's urgent anyway... > No, please send this one, I don't want to introduce new warnings in 3.17. Arnd
On Mon, Jul 28, 2014 at 12:21:34PM +0200, Arnd Bergmann wrote: > On Monday 28 July 2014 11:35:32 Maxime Ripard wrote: > > On Mon, Jul 21, 2014 at 10:54:27PM +0800, Chen-Yu Tsai wrote: > > > dtc was giving warnings for missing #address-cells and #size-cells for > > > the new sun6i-a31-hummingbird.dts, which has a i2c-based rtc device. > > > > > > This patch adds the properties for all i2c controller nodes for sun6i. > > > > > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > > > Applied, thanks. > > > > I don't plan on sending more DT pull-request unless something big > > shows up, so it's probably queued for 3.18. > > > > It's not like it's urgent anyway... > > > > No, please send this one, I don't want to introduce new warnings > in 3.17. I didn't think we had a user for i2c yet, but yeah, we just got one. I'll send it for 3.17 then. Maxime
diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi index 44b07e5..e06fbfc 100644 --- a/arch/arm/boot/dts/sun6i-a31.dtsi +++ b/arch/arm/boot/dts/sun6i-a31.dtsi @@ -660,6 +660,8 @@ clock-frequency = <100000>; resets = <&apb2_rst 0>; status = "disabled"; + #address-cells = <1>; + #size-cells = <0>; }; i2c1: i2c@01c2b000 { @@ -670,6 +672,8 @@ clock-frequency = <100000>; resets = <&apb2_rst 1>; status = "disabled"; + #address-cells = <1>; + #size-cells = <0>; }; i2c2: i2c@01c2b400 { @@ -680,6 +684,8 @@ clock-frequency = <100000>; resets = <&apb2_rst 2>; status = "disabled"; + #address-cells = <1>; + #size-cells = <0>; }; i2c3: i2c@01c2b800 { @@ -690,6 +696,8 @@ clock-frequency = <100000>; resets = <&apb2_rst 3>; status = "disabled"; + #address-cells = <1>; + #size-cells = <0>; }; gmac: ethernet@01c30000 {
dtc was giving warnings for missing #address-cells and #size-cells for the new sun6i-a31-hummingbird.dts, which has a i2c-based rtc device. This patch adds the properties for all i2c controller nodes for sun6i. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- Hi Maxime, This is a fix to get rid of warnings from dtc when building sun6i dts. Sorry for now catching it earlier. Cheers ChenYu --- arch/arm/boot/dts/sun6i-a31.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)