UWB Kconfig: cannot set UWB to N in gconfig
diff mbox

Message ID 1252577154.2340.12.camel@castor
State New, archived
Headers show

Commit Message

richard kennedy Sept. 10, 2009, 10:05 a.m. UTC
I sometimes use 'make gconfig' and I noticed that I cannot disable the
UWB option -- it just won't let me set it to N.

AFAICT this is because the CONFIG USB_WUSB selects UWB which forces it
on.
applying this patch fixes the issue but I'm not sure if this is the
right way to go about it.

any thoughts?

regards
Richard

This is against 2.6.31




--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Randy Dunlap Sept. 10, 2009, 4:08 p.m. UTC | #1
On Thu, 10 Sep 2009 11:05:54 +0100 Richard Kennedy wrote:

> I sometimes use 'make gconfig' and I noticed that I cannot disable the
> UWB option -- it just won't let me set it to N.

Not specific to 'gconfig'.

> AFAICT this is because the CONFIG USB_WUSB selects UWB which forces it
> on.

Yes.

> applying this patch fixes the issue but I'm not sure if this is the
> right way to go about it.
> 
> any thoughts?

UWB can be disabled by disabling both of these options that are several
entries below it in the same menu:

USB_WHCI_HCD and USB_HWA_HCD

and then returning to UWB and disabling it.

Should users have to figure that out?  no.


> This is against 2.6.31
> 
> 
> diff --git a/drivers/usb/wusbcore/Kconfig b/drivers/usb/wusbcore/Kconfig
> index eb09a0a..cc97041 100644
> --- a/drivers/usb/wusbcore/Kconfig
> +++ b/drivers/usb/wusbcore/Kconfig
> @@ -5,7 +5,7 @@ config USB_WUSB
>  	tristate "Enable Wireless USB extensions (EXPERIMENTAL)"
>  	depends on EXPERIMENTAL
>  	depends on USB
> -        select UWB
> +        depends on UWB
>          select CRYPTO
>          select CRYPTO_BLKCIPHER
>          select CRYPTO_CBC

use tabs, not spaces.


---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Vrabel Sept. 14, 2009, 10:34 a.m. UTC | #2
Richard Kennedy wrote:
> I sometimes use 'make gconfig' and I noticed that I cannot disable the
> UWB option -- it just won't let me set it to N.
> 
> AFAICT this is because the CONFIG USB_WUSB selects UWB which forces it
> on.
> applying this patch fixes the issue but I'm not sure if this is the
> right way to go about it.
> 
> any thoughts?
> 
> regards
> Richard
> 
> This is against 2.6.31
> 
> 
> diff --git a/drivers/usb/wusbcore/Kconfig b/drivers/usb/wusbcore/Kconfig
> index eb09a0a..cc97041 100644
> --- a/drivers/usb/wusbcore/Kconfig
> +++ b/drivers/usb/wusbcore/Kconfig
> @@ -5,7 +5,7 @@ config USB_WUSB
>  	tristate "Enable Wireless USB extensions (EXPERIMENTAL)"
>  	depends on EXPERIMENTAL
>  	depends on USB
> -        select UWB
> +        depends on UWB

NAK.  It's not sufficiently obvious to a user that Wireless USB support
requires UWB.

This is really an issue with the configuration application.  Consider
improving them to allow switching off select'ed options and popping up a
dialog that says "switching off UWB will also switch off WUSB" etc.

David

Patch
diff mbox

diff --git a/drivers/usb/wusbcore/Kconfig b/drivers/usb/wusbcore/Kconfig
index eb09a0a..cc97041 100644
--- a/drivers/usb/wusbcore/Kconfig
+++ b/drivers/usb/wusbcore/Kconfig
@@ -5,7 +5,7 @@  config USB_WUSB
 	tristate "Enable Wireless USB extensions (EXPERIMENTAL)"
 	depends on EXPERIMENTAL
 	depends on USB
-        select UWB
+        depends on UWB
         select CRYPTO
         select CRYPTO_BLKCIPHER
         select CRYPTO_CBC