Samsung R510
diff mbox

Message ID f3f71ab90909110117t4d9de95cv2f71b42f2a9a7992@mail.gmail.com
State Rejected
Headers show

Commit Message

Mike Lothian Sept. 11, 2009, 8:17 a.m. UTC
Hi

Please could the following patch be added to the kernel

                .ident = "Fujitsu Amilo PA 1510",
                .matches = {

This fixes the forced release keys for me

Thanks

Mike

PS I'm not subscribed to this list so please CC me
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Mike Lothian Sept. 15, 2009, 9:03 p.m. UTC | #1
2009/9/11 Mike Lothian <mike@fireburn.co.uk>:
> Hi
>
> Please could the following patch be added to the kernel
>
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index 95fe045..592623e 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -1572,6 +1572,16 @@ static struct dmi_system_id
> atkbd_dmi_quirk_table[] __initdata = {
>                .callback = atkbd_setup_forced_release,
>                .driver_data = atkbd_samsung_forced_release_keys,
>        },
> +        {
> +                .ident = "Samsung R510/P510",
> +                .matches = {
> +                        DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG
> ELECTRONICS CO., LTD."),
> +                        DMI_MATCH(DMI_PRODUCT_NAME, "R510/P510"),
> +                },
> +                .callback = atkbd_setup_forced_release,
> +                .driver_data = atkbd_samsung_forced_release_keys,
> +        },
> +
>        {
>                .ident = "Fujitsu Amilo PA 1510",
>                .matches = {
>
> This fixes the forced release keys for me
>
> Thanks
>
> Mike
>
> PS I'm not subscribed to this list so please CC me
>

Ping is this the correct list?
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dmitry Torokhov Sept. 16, 2009, 3:46 a.m. UTC | #2
Hi Mike,

On Tue, Sep 15, 2009 at 10:03:25PM +0100, Mike Lothian wrote:
> 2009/9/11 Mike Lothian <mike@fireburn.co.uk>:
> > Hi
> >
> > Please could the following patch be added to the kernel
> >
> > diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> > index 95fe045..592623e 100644
> > --- a/drivers/input/keyboard/atkbd.c
> > +++ b/drivers/input/keyboard/atkbd.c
> > @@ -1572,6 +1572,16 @@ static struct dmi_system_id
> > atkbd_dmi_quirk_table[] __initdata = {
> >                .callback = atkbd_setup_forced_release,
> >                .driver_data = atkbd_samsung_forced_release_keys,
> >        },
> > +        {
> > +                .ident = "Samsung R510/P510",
> > +                .matches = {
> > +                        DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG
> > ELECTRONICS CO., LTD."),
> > +                        DMI_MATCH(DMI_PRODUCT_NAME, "R510/P510"),
> > +                },
> > +                .callback = atkbd_setup_forced_release,
> > +                .driver_data = atkbd_samsung_forced_release_keys,
> > +        },
> > +
> >        {
> >                .ident = "Fujitsu Amilo PA 1510",
> >                .matches = {
> >
> > This fixes the forced release keys for me
> >
> > Thanks
> >
> > Mike
> >
> > PS I'm not subscribed to this list so please CC me
> >
> 
> Ping is this the correct list?

This is correct list. However atkbd has just been adjusted to allow
manipulating the force release bitmap from userspace (via sysfs) so no
more patches will be accepted in the kernel. We will rely on UDEV/HAL to
take care of setting it up properly.

Patch
diff mbox

diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index 95fe045..592623e 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -1572,6 +1572,16 @@  static struct dmi_system_id
atkbd_dmi_quirk_table[] __initdata = {
                .callback = atkbd_setup_forced_release,
                .driver_data = atkbd_samsung_forced_release_keys,
        },
+        {
+                .ident = "Samsung R510/P510",
+                .matches = {
+                        DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG
ELECTRONICS CO., LTD."),
+                        DMI_MATCH(DMI_PRODUCT_NAME, "R510/P510"),
+                },
+                .callback = atkbd_setup_forced_release,
+                .driver_data = atkbd_samsung_forced_release_keys,
+        },
+
        {