From patchwork Wed Aug 6 20:32:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 4688471 Return-Path: X-Original-To: patchwork-ocfs2-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 56037C0338 for ; Wed, 6 Aug 2014 20:32:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8BC6820145 for ; Wed, 6 Aug 2014 20:32:52 +0000 (UTC) Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96BC520125 for ; Wed, 6 Aug 2014 20:32:51 +0000 (UTC) Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s76KWhpi019726 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Aug 2014 20:32:44 GMT Received: from oss.oracle.com (oss-external.oracle.com [137.254.96.51]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s76KWhBe001347 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 6 Aug 2014 20:32:43 GMT Received: from localhost ([127.0.0.1] helo=oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1XF7t4-0003qb-UK; Wed, 06 Aug 2014 13:32:42 -0700 Received: from acsinet22.oracle.com ([141.146.126.238]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1XF7sz-0003qP-GL for ocfs2-devel@oss.oracle.com; Wed, 06 Aug 2014 13:32:37 -0700 Received: from userp1020.oracle.com (userp1020.oracle.com [156.151.31.79]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s76KWa0i010438 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 6 Aug 2014 20:32:37 GMT Received: from userp2020.oracle.com (userp2020.oracle.com [156.151.31.84]) by userp1020.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s76KWaa6027641 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 6 Aug 2014 20:32:36 GMT Received: from pps.filterd (userp2020.oracle.com [127.0.0.1]) by userp2020.oracle.com (8.14.7/8.14.7) with SMTP id s76KWaHg035695 for ; Wed, 6 Aug 2014 20:32:36 GMT Received: from mail-pd0-f201.google.com (mail-pd0-f201.google.com [209.85.192.201]) by userp2020.oracle.com with ESMTP id 1nknw4ktpc-1 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Wed, 06 Aug 2014 20:32:31 +0000 Received: by mail-pd0-f201.google.com with SMTP id g10so788938pdj.4 for ; Wed, 06 Aug 2014 13:32:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:user-agent :mime-version:content-type:content-transfer-encoding; bh=w4wJvdLfz/qak6dzwfF7KKh3cTOe6AaenymsRM6VDJ0=; b=WqSFextCMw4LUf7EAgPBLhwJXXntUHeCziNZnw1aQ2k+mYuAERrIQnSQSFuexDI5g8 GDGHeRicqlsD/vCnEJnOfaxfQiyegMX01J1S+HRtAfnSfWzi3RSKnA3bORzRuyy32zgU s0uxzopbEPYFDhLISQgHwK1wh1mmEyDBw1vq5uf6AYIxISstkeaBhL01c86bILIchROe oiADo6CJ08w2Mm3BsTKaLcfl8tI6KLKXyu9qbg44CalPVTTGyBEYHwoxMDQeFWXjWPVv 5j2/Sp7meOvYDnpaJVA0/eFbuRMkW478WoTs5VWWUj9Ap3ZUCMNRTTn0kZmwn4Y7efES qFkQ== X-Gm-Message-State: ALoCoQmTwxORGzD7+a7s020Rmt8vQz2Bg7Hjqrb0w1KsnBhcfZMM3JHM88Jd9xRDNgedcZUUW2zc X-Received: by 10.66.187.8 with SMTP id fo8mr7139409pac.32.1407357129774; Wed, 06 Aug 2014 13:32:09 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id l23si140789yhg.1.2014.08.06.13.32.09 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Aug 2014 13:32:09 -0700 (PDT) Received: from akpm3.mtv.corp.google.com (akpm3.mtv.corp.google.com [172.17.131.127]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id 960705A4586; Wed, 6 Aug 2014 13:32:09 -0700 (PDT) Received: by akpm3.mtv.corp.google.com (Postfix, from userid 25780) id 59AA11A0536; Wed, 6 Aug 2014 13:32:09 -0700 (PDT) Date: Wed, 06 Aug 2014 13:32:09 -0700 From: akpm@linux-foundation.org To: jlbec@evilplan.org, mfasheh@suse.com, ocfs2-devel@oss.oracle.com, akpm@linux-foundation.org, junxiao.bi@oracle.com, joseph.qi@huawei.com, srinivas.eeda@oracle.com Message-ID: <53e290c9.EQXL/jgd0x3ijQtm%akpm@linux-foundation.org> User-Agent: Heirloom mailx 12.5 6/20/10 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5600 definitions=7522 signatures=670497 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1408060245 Subject: [Ocfs2-devel] [patch 05/10] ocfs2: quorum: add a log for node not fenced X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Junxiao Bi Subject: ocfs2: quorum: add a log for node not fenced For debug use, we can see from the log whether the fence decision is made and why it is not fenced. Signed-off-by: Junxiao Bi Reviewed-by: Srinivas Eeda Cc: Mark Fasheh Cc: Joel Becker Cc: Joseph Qi Signed-off-by: Andrew Morton Reviewed-by: Mark Fasheh --- fs/ocfs2/cluster/quorum.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff -puN fs/ocfs2/cluster/quorum.c~ocfs2-quorum-add-a-log-for-node-not-fenced fs/ocfs2/cluster/quorum.c --- a/fs/ocfs2/cluster/quorum.c~ocfs2-quorum-add-a-log-for-node-not-fenced +++ a/fs/ocfs2/cluster/quorum.c @@ -160,9 +160,18 @@ static void o2quo_make_decision(struct w } out: - spin_unlock(&qs->qs_lock); - if (fence) + if (fence) { + spin_unlock(&qs->qs_lock); o2quo_fence_self(); + } else { + mlog(ML_NOTICE, "not fencing this node, heartbeating: %d, " + "connected: %d, lowest: %d (%sreachable)\n", + qs->qs_heartbeating, qs->qs_connected, lowest_hb, + lowest_reachable ? "" : "un"); + spin_unlock(&qs->qs_lock); + + } + } static void o2quo_set_hold(struct o2quo_state *qs, u8 node)