[v1] net: ethernet: arc: Don't free Rockchip resources before disconnect from phy
diff mbox

Message ID 1410335473-23573-1-git-send-email-romain.perier@gmail.com
State New, archived
Headers show

Commit Message

Romain Perier Sept. 10, 2014, 7:51 a.m. UTC
Free resources before being disconnected from phy and calling core driver is
wrong and should not happen. It avoids a delay of 4-5s caused by the timeout of
phy_disconnect().

Signed-off-by: Romain Perier <romain.perier@gmail.com>
---
 drivers/net/ethernet/arc/emac_rockchip.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

David Miller Sept. 10, 2014, 8:03 p.m. UTC | #1
From: Romain Perier <romain.perier@gmail.com>
Date: Wed, 10 Sep 2014 07:51:13 +0000

> Free resources before being disconnected from phy and calling core driver is
> wrong and should not happen. It avoids a delay of 4-5s caused by the timeout of
> phy_disconnect().
> 
> Signed-off-by: Romain Perier <romain.perier@gmail.com>

Applied, thanks.

Patch
diff mbox

diff --git a/drivers/net/ethernet/arc/emac_rockchip.c b/drivers/net/ethernet/arc/emac_rockchip.c
index 51d0585..c31c740 100644
--- a/drivers/net/ethernet/arc/emac_rockchip.c
+++ b/drivers/net/ethernet/arc/emac_rockchip.c
@@ -202,12 +202,13 @@  static int emac_rockchip_remove(struct platform_device *pdev)
 	struct rockchip_priv_data *priv = netdev_priv(ndev);
 	int err;
 
+	err = arc_emac_remove(ndev);
+
 	clk_disable_unprepare(priv->refclk);
 
 	if (priv->regulator)
 		regulator_disable(priv->regulator);
 
-	err = arc_emac_remove(ndev);
 	free_netdev(ndev);
 	return err;
 }