From patchwork Sun Sep 14 14:45:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Epler X-Patchwork-Id: 4901511 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 27B43BEEA5 for ; Sun, 14 Sep 2014 15:06:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 377EF2018E for ; Sun, 14 Sep 2014 15:06:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6AF3020220 for ; Sun, 14 Sep 2014 15:06:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752605AbaINPGi (ORCPT ); Sun, 14 Sep 2014 11:06:38 -0400 Received: from rrcs-76-79-27-186.west.biz.rr.com ([76.79.27.186]:28524 "EHLO rrcs-76-79-27-186.west.biz.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752595AbaINPGh (ORCPT ); Sun, 14 Sep 2014 11:06:37 -0400 Received: from jepler by zaphod.unpythonic.net with local (Exim 4.80) (envelope-from ) id 1XTB36-0005RS-Fh; Sun, 14 Sep 2014 09:45:08 -0500 From: Jeff Epler To: linux@vger.kernel.org, linux-spi@vger.kernel.org Subject: [RFC 3/4] spidev: actually use synchronous transfers Date: Sun, 14 Sep 2014 09:45:07 -0500 Message-Id: <1410705908-20847-4-git-send-email-jepler@unpythonic.net> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1410705908-20847-1-git-send-email-jepler@unpythonic.net> References: <1410705908-20847-1-git-send-email-jepler@unpythonic.net> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP this reduces a source of latency --- drivers/spi/spidev.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index dda7632..6e37c59 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -120,15 +120,9 @@ spidev_sync(struct spidev_data *spidev, struct spi_message *message) if (spidev->spi == NULL) status = -ESHUTDOWN; else - status = spi_async(spidev->spi, message); + status = spi_sync(spidev->spi, message); spin_unlock_irq(&spidev->spi_lock); - if (status == 0) { - wait_for_completion(&done); - status = message->status; - if (status == 0) - status = message->actual_length; - } return status; }