diff mbox

[4/5] drm/i915: Enable the debug of SDVO command/response

Message ID 1253524724-23349-4-git-send-email-yakui.zhao@intel.com (mailing list archive)
State Superseded
Headers show

Commit Message

Zhao, Yakui Sept. 21, 2009, 9:18 a.m. UTC 
From: Zhao Yakui <yakui.zhao@intel.com>

Enable the debug of SDVO command/response

Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
---
 drivers/gpu/drm/i915/intel_sdvo.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Zhenyu Wang Sept. 22, 2009, 6:55 a.m. UTC | #1 
On 2009.09.21 17:18:43 +0800, yakui.zhao@intel.com wrote:
> From: Zhao Yakui <yakui.zhao@intel.com>
> 
> Enable the debug of SDVO command/response
> 
> Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_sdvo.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
> index 083bec2..deb44f2 100644
> --- a/drivers/gpu/drm/i915/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> @@ -37,7 +37,7 @@
>  #include "intel_sdvo_regs.h"
>  
>  #undef SDVO_DEBUG
> -
> +#define SDVO_DEBUG 1
>  static char *tv_format_names[] = {
>  	"NTSC_M"   , "NTSC_J"  , "NTSC_443",
>  	"PAL_B"    , "PAL_D"   , "PAL_G"   ,

Why not just remove all SDVO_DEBUG?
Zhao, Yakui Sept. 23, 2009, 3:43 a.m. UTC | #2 
On Tue, 2009-09-22 at 14:55 +0800, Zhenyu Wang wrote:
> On 2009.09.21 17:18:43 +0800, yakui.zhao@intel.com wrote:
> > From: Zhao Yakui <yakui.zhao@intel.com>
> > 
> > Enable the debug of SDVO command/response
> > 
> > Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_sdvo.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
> > index 083bec2..deb44f2 100644
> > --- a/drivers/gpu/drm/i915/intel_sdvo.c
> > +++ b/drivers/gpu/drm/i915/intel_sdvo.c
> > @@ -37,7 +37,7 @@
> >  #include "intel_sdvo_regs.h"
> >  
> >  #undef SDVO_DEBUG
> > -
> > +#define SDVO_DEBUG 1
> >  static char *tv_format_names[] = {
> >  	"NTSC_M"   , "NTSC_J"  , "NTSC_443",
> >  	"PAL_B"    , "PAL_D"   , "PAL_G"   ,
> 
> Why not just remove all SDVO_DEBUG?
It is also ok to remove the SDVO_DEBUG.

Thanks.
   Yakui
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
index 083bec2..deb44f2 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -37,7 +37,7 @@ 
 #include "intel_sdvo_regs.h"
 
 #undef SDVO_DEBUG
-
+#define SDVO_DEBUG 1
 static char *tv_format_names[] = {
 	"NTSC_M"   , "NTSC_J"  , "NTSC_443",
 	"PAL_B"    , "PAL_D"   , "PAL_G"   ,