| Message ID | 1410900696-6481-9-git-send-email-linux@rasmusvillemoes.dk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8bb1ffdf76276c040a065c4df173dfce98b5ffa3 |
| Delegated to: | Takashi Iwai |
| Headers | show |
At Tue, 16 Sep 2014 22:51:22 +0200, Rasmus Villemoes wrote: > > The kernel used to contain two functions for length-delimited, > case-insensitive string comparison, strnicmp with correct semantics > and a slightly buggy strncasecmp. The latter is the POSIX name, so > strnicmp was renamed to strncasecmp, and strnicmp made into a wrapper > for the new strncasecmp to avoid breaking existing users. > > To allow the compat wrapper strnicmp to be removed at some point in > the future, and to avoid the extra indirection cost, do > s/strnicmp/strncasecmp/g. > > Cc: Jaroslav Kysela <perex@perex.cz> > Cc: Takashi Iwai <tiwai@suse.de> > Cc: alsa-devel@alsa-project.org > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Applied, thanks. Takashi > --- > sound/pci/hda/hda_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/hda/hda_sysfs.c b/sound/pci/hda/hda_sysfs.c > index e207909..9b49f15 100644 > --- a/sound/pci/hda/hda_sysfs.c > +++ b/sound/pci/hda/hda_sysfs.c > @@ -514,7 +514,7 @@ enum { > > static inline int strmatch(const char *a, const char *b) > { > - return strnicmp(a, b, strlen(b)) == 0; > + return strncasecmp(a, b, strlen(b)) == 0; > } > > /* parse the contents after the line "[codec]" > -- > 2.0.4 >
diff --git a/sound/pci/hda/hda_sysfs.c b/sound/pci/hda/hda_sysfs.c index e207909..9b49f15 100644 --- a/sound/pci/hda/hda_sysfs.c +++ b/sound/pci/hda/hda_sysfs.c @@ -514,7 +514,7 @@ enum { static inline int strmatch(const char *a, const char *b) { - return strnicmp(a, b, strlen(b)) == 0; + return strncasecmp(a, b, strlen(b)) == 0; } /* parse the contents after the line "[codec]"
The kernel used to contain two functions for length-delimited, case-insensitive string comparison, strnicmp with correct semantics and a slightly buggy strncasecmp. The latter is the POSIX name, so strnicmp was renamed to strncasecmp, and strnicmp made into a wrapper for the new strncasecmp to avoid breaking existing users. To allow the compat wrapper strnicmp to be removed at some point in the future, and to avoid the extra indirection cost, do s/strnicmp/strncasecmp/g. Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.de> Cc: alsa-devel@alsa-project.org Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- sound/pci/hda/hda_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)