From patchwork Tue Sep 22 14:11:43 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Raphael Derosso Pereira X-Patchwork-Id: 49292 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n8MEJ5n4025080 for ; Tue, 22 Sep 2009 14:19:05 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756597AbZIVOSx (ORCPT ); Tue, 22 Sep 2009 10:18:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756361AbZIVOSx (ORCPT ); Tue, 22 Sep 2009 10:18:53 -0400 Received: from an-out-0708.google.com ([209.85.132.244]:15277 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755913AbZIVOSw convert rfc822-to-8bit (ORCPT ); Tue, 22 Sep 2009 10:18:52 -0400 Received: by an-out-0708.google.com with SMTP id d40so5079945and.1 for ; Tue, 22 Sep 2009 07:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=ZHiHZn75TozRlRk+s3Pbmyz6uqPa0rrkxB40iNER82s=; b=uGHQSiWqrhvIHflnDIfQ0fpqi2HtiPsblrNa9fnuki0TgNXCN0A6cy1uNiLNUc7EIp JL9biHcrYQFjVwgt1N0tud2OnjeumgMRzYnQvwIW8WW4p23ruK4ucPTZxp2xKkc8U53K P+yHyUkBShUCiM/7P8LDcdu97VK+MmCV54pqc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=sPAGhM5XzdLzii1t5u5SkNY/e2Ff/YJOKmeX5xZoxSIkVV9Zt0c9mpvVEkhVZvVHWv uEKkMtZdM0rjP/O/Jt9DAav+3Ylv3gGck1z2ZExHlGIDwTiTVggI7v6hRKH9mzUPxoQf 1P1yWSSl3On287lpvYAR+fmBUszAe0U+9ZHoQ= MIME-Version: 1.0 Received: by 10.101.9.15 with SMTP id m15mr1036328ani.94.1253628703888; Tue, 22 Sep 2009 07:11:43 -0700 (PDT) In-Reply-To: References: <20090915042612.GB1132@core.coreip.homeip.net> <20090922055252.GA9658@core.coreip.homeip.net> Date: Tue, 22 Sep 2009 11:11:43 -0300 Message-ID: Subject: Re: [PATCH] Atmel AT42QT2160 sensor chip input driver From: Raphael Derosso Pereira To: Dmitry Torokhov Cc: linux-input@vger.kernel.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hello Dmitry, I managed to get a working copy of your 'for-linus' branch. I compiled and tested it and it is working fine! I would just remove the first #include as it was only added for the CONFIG_QT2160_DEBUG you removed. Also, this chip is capable of performing some ajustments, like adding keys to groups to avoid double detection, setting up sensibility, detection thresholds, etc... I was wondering how to put that to userspace, through sysfs, evdev ioctl or a /dev entry. What do you suggest??? --- From: Raphael Derosso Pereira Inclusion cleanup Signed-off-by: Raphael Derosso Pereira -- 2009/9/22 Raphael Derosso Pereira : > Hello, > > 2009/9/22 Dmitry Torokhov : >> Hi Raphael, >> >> >> I don't think we need a Kconfig entry for debugging. A person who wants >> to debug such driver can easily turn on debugging manually. > > Ok. > >> >> We normally try to allocate all necessary resources in probe() so that >> if device is bound to a driver it should work unless it is broken. Since >> there is no way to shut off IRQs while IRQ handler is registered it does >> not make sense to have open and close if we allocate IRQ in probe(). > > Agreed. > >> >> Please take a look at the latest version that I have in 'for-linus' >> branch in my tree on kernel.org and shout if you see something wrong. > > How am I supposed to do that? > >> >> Thanks. >> >> -- >> Dmitry >> > > > > -- > Raphael Derosso Pereira > Engenheiro de Computação > msn: rderossopereira@hotmail.com > Skype: rderossopereira > diff --git a/drivers/input/keyboard/qt2160.c b/drivers/input/keyboard/qt2160.c index 0d57c17..191cc51 100644 --- a/drivers/input/keyboard/qt2160.c +++ b/drivers/input/keyboard/qt2160.c @@ -18,8 +18,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -#include - #include #include #include