[2/6,OPW,kernel] staging: media: lirc: fix quoted string split across line
diff mbox

Message ID 327a18a0ebd54d9b8e05c805250321729c8323ac.1411278275.git.tapaswenipathak@gmail.com
State New, archived
Headers show

Commit Message

Tapasweni Pathak Sept. 21, 2014, 6:19 a.m. UTC
This patch fixes checkpatch.pl warning in files of media/lirc
WARNING : quoted string split across lines

Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
---
 drivers/staging/media/lirc/lirc_imon.c   |   12 +++++++-----
 drivers/staging/media/lirc/lirc_serial.c |   12 ++++++------
 2 files changed, 13 insertions(+), 11 deletions(-)

--
1.7.0.4

Comments

Greg KH Sept. 23, 2014, 6:12 p.m. UTC | #1
On Sun, Sep 21, 2014 at 11:49:18AM +0530, Tapasweni Pathak wrote:
> This patch fixes checkpatch.pl warning in files of media/lirc
> WARNING : quoted string split across lines
> 
> Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
> ---
>  drivers/staging/media/lirc/lirc_imon.c   |   12 +++++++-----
>  drivers/staging/media/lirc/lirc_serial.c |   12 ++++++------
>  2 files changed, 13 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c
> index 96c76b3..727f83c 100644
> --- a/drivers/staging/media/lirc/lirc_imon.c
> +++ b/drivers/staging/media/lirc/lirc_imon.c
> @@ -615,8 +615,9 @@ static void imon_incoming_packet(struct imon_context *context,
>  		return;
> 
>  	if (len != 8) {
> -		dev_warn(dev, "imon %s: invalid incoming packet "
> -			 "size (len = %d, intf%d)\n", __func__, len, intf);
> +		dev_warn(dev,
> +				"imon %s: invalid incoming packet size (len = %d, intf%d)\n",
> +				__func__, len, intf);

Put the string on the dev_warn() line, please.

Patch
diff mbox

diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c
index 96c76b3..727f83c 100644
--- a/drivers/staging/media/lirc/lirc_imon.c
+++ b/drivers/staging/media/lirc/lirc_imon.c
@@ -615,8 +615,9 @@  static void imon_incoming_packet(struct imon_context *context,
 		return;

 	if (len != 8) {
-		dev_warn(dev, "imon %s: invalid incoming packet "
-			 "size (len = %d, intf%d)\n", __func__, len, intf);
+		dev_warn(dev,
+				"imon %s: invalid incoming packet size (len = %d, intf%d)\n",
+				__func__, len, intf);
 		return;
 	}

@@ -925,9 +926,10 @@  static int imon_probe(struct usb_interface *interface,
 		}
 	}

-	dev_info(dev, "iMON device (%04x:%04x, intf%d) on "
-		 "usb<%d:%d> initialized\n", vendor, product, ifnum,
-		 usbdev->bus->busnum, usbdev->devnum);
+	dev_info(dev,
+		"iMON device (%04x:%04x, intf%d) on usb<%d:%d> initialized\n",
+		vendor, product, ifnum,
+		usbdev->bus->busnum, usbdev->devnum);

 unlock:
 	mutex_unlock(&context->ctx_lock);
diff --git a/drivers/staging/media/lirc/lirc_serial.c b/drivers/staging/media/lirc/lirc_serial.c
index 80d2e28..1eb5b32 100644
--- a/drivers/staging/media/lirc/lirc_serial.c
+++ b/drivers/staging/media/lirc/lirc_serial.c
@@ -1184,8 +1184,8 @@  MODULE_PARM_DESC(io, "I/O address base (0x3f8 or 0x2f8)");

 /* some architectures (e.g. intel xscale) have memory mapped registers */
 module_param(iommap, bool, S_IRUGO);
-MODULE_PARM_DESC(iommap, "physical base for memory mapped I/O"
-		" (0 = no memory mapped io)");
+MODULE_PARM_DESC(iommap,
+		"physical base for memory mapped I/O (0 = no memory mapped io)");

 /*
  * some architectures (e.g. intel xscale) align the 8bit serial registers
@@ -1202,13 +1202,13 @@  module_param(share_irq, bool, S_IRUGO);
 MODULE_PARM_DESC(share_irq, "Share interrupts (0 = off, 1 = on)");

 module_param(sense, int, S_IRUGO);
-MODULE_PARM_DESC(sense, "Override autodetection of IR receiver circuit"
-		 " (0 = active high, 1 = active low )");
+MODULE_PARM_DESC(sense,
+		"Override autodetection of IR receiver circuit (0 = active high, 1 = active low )");

 #ifdef CONFIG_LIRC_SERIAL_TRANSMITTER
 module_param(txsense, bool, S_IRUGO);
-MODULE_PARM_DESC(txsense, "Sense of transmitter circuit"
-		 " (0 = active high, 1 = active low )");
+MODULE_PARM_DESC(txsense,
+				"Sense of transmitter circuit (0 = active high, 1 = active low )");
 #endif

 module_param(softcarrier, bool, S_IRUGO);