[3/6,OPW,kernel] staging: media: lirc: break quoted strings at a space character
diff mbox

Message ID c7361feccf489ef0937cb7beb60974962ef2e7c8.1411278275.git.tapaswenipathak@gmail.com
State New, archived
Headers show

Commit Message

Tapasweni Pathak Sept. 21, 2014, 6:20 a.m. UTC
This patch fixes checkpatch.pl warning in lirc_zilog.c file
WARNING :  break quoted strings at a space character

Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
---
 drivers/staging/media/lirc/lirc_zilog.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

--
1.7.0.4

Comments

Julia Lawall Sept. 21, 2014, 6:26 a.m. UTC | #1
On Sun, 21 Sep 2014, Tapasweni Pathak wrote:

> This patch fixes checkpatch.pl warning in lirc_zilog.c file
> WARNING :  break quoted strings at a space character
>
> Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
> ---
>  drivers/staging/media/lirc/lirc_zilog.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
> index 0bf4bb3..e2e1236 100644
> --- a/drivers/staging/media/lirc/lirc_zilog.c
> +++ b/drivers/staging/media/lirc/lirc_zilog.c
> @@ -806,7 +806,7 @@ static int fw_load(struct IR_tx *tx)
>  		goto corrupt;
>  	if (version != 1) {
>  		zilog_error("unsupported code set file version (%u, expected"
> -			    "1) -- please upgrade to a newer driver",
> +			    " 1) -- please upgrade to a newer driver",

Maybe it would be nicer to put the space after "expected" than at the
beginning of a string?

julia

>  			    version);
>  		fw_unload_locked();
>  		ret = -EFAULT;
> --
> 1.7.0.4
>
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Tapasweni Pathak Sept. 21, 2014, 6:31 a.m. UTC | #2
On Sun, Sep 21, 2014 at 11:56 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:

>
>
> On Sun, 21 Sep 2014, Tapasweni Pathak wrote:
>
> > This patch fixes checkpatch.pl warning in lirc_zilog.c file
> > WARNING :  break quoted strings at a space character
> >
> > Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
> > ---
> >  drivers/staging/media/lirc/lirc_zilog.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/media/lirc/lirc_zilog.c
> b/drivers/staging/media/lirc/lirc_zilog.c
> > index 0bf4bb3..e2e1236 100644
> > --- a/drivers/staging/media/lirc/lirc_zilog.c
> > +++ b/drivers/staging/media/lirc/lirc_zilog.c
> > @@ -806,7 +806,7 @@ static int fw_load(struct IR_tx *tx)
> >               goto corrupt;
> >       if (version != 1) {
> >               zilog_error("unsupported code set file version (%u,
> expected"
> > -                         "1) -- please upgrade to a newer driver",
> > +                         " 1) -- please upgrade to a newer driver",
>
> Maybe it would be nicer to put the space after "expected" than at the
> beginning of a string?
>
> julia
>

Should I resend the complete series or just this one?

>
> >                           version);
> >               fw_unload_locked();
> >               ret = -EFAULT;
> > --
> > 1.7.0.4
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "opw-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to opw-kernel+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
Julia Lawall Sept. 21, 2014, 6:33 a.m. UTC | #3
> Should I resend the complete series or just this one? 

The complete series.  For most, you would indicate under the --- that it
has not changed.

julia
Julia Lawall Sept. 21, 2014, 6:34 a.m. UTC | #4
> Maybe it would be nicer to put the space after "expected" than at the
> beginning of a string?
>
> julia
>
>
> Should I resend the complete series or just this one? 

Be sure to run checkpatch on the result, because another one of your
patches suggests that it will complain about the string being broken up at
all.

julia
Julia Lawall Sept. 21, 2014, 6:36 a.m. UTC | #5
Your emails also have a strange address CC that bounces, for example:

  Date: Sun, 21 Sep 2014 08:34:57 +0200 (CEST)
  From: Julia Lawall <julia.lawall@lip6.fr>
  To: Tapasweni Pathak <tapaswenipathak@gmail.com>
  Cc: cover.1411278275.git.tapaswenipathak@gmail.com,
      opw-kernel <opw-kernel@googlegroups.com>

julia
Tapasweni Pathak Sept. 21, 2014, 6:46 a.m. UTC | #6
On Sunday, September 21, 2014 12:05:01 PM UTC+5:30, Julia Lawall wrote:
>
> > Maybe it would be nicer to put the space after "expected" than at the 
> > beginning of a string? 
> > 
> > julia 
> > 
> > 
> > Should I resend the complete series or just this one?  
>
> Be sure to run checkpatch on the result, because another one of your 
> patches suggests that it will complain about the string being broken up at 
> all. 
>
> Yeah. I ran the checkpatch.pl on all my patches and I fixed all warnings 
and errors. (if popped up). are you talking about the line fixed in this 
patch? checkpatch showed two warnings for the same line, one I fixed and 
the other if fixed, either generate a 80 character warning or the same 
warning again. 

> julia
Josh Triplett Sept. 25, 2014, 6:39 p.m. UTC | #7
On Sun, Sep 21, 2014 at 08:36:46AM +0200, Julia Lawall wrote:
> Your emails also have a strange address CC that bounces, for example:
> 
>   Date: Sun, 21 Sep 2014 08:34:57 +0200 (CEST)
>   From: Julia Lawall <julia.lawall@lip6.fr>
>   To: Tapasweni Pathak <tapaswenipathak@gmail.com>
>   Cc: cover.1411278275.git.tapaswenipathak@gmail.com,
>       opw-kernel <opw-kernel@googlegroups.com>

That looks like a Message-Id generated by git format-patch; it isn't a
valid email address, and shouldn't be CCed.

- Josh Triplett

Patch
diff mbox

diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
index 0bf4bb3..e2e1236 100644
--- a/drivers/staging/media/lirc/lirc_zilog.c
+++ b/drivers/staging/media/lirc/lirc_zilog.c
@@ -806,7 +806,7 @@  static int fw_load(struct IR_tx *tx)
 		goto corrupt;
 	if (version != 1) {
 		zilog_error("unsupported code set file version (%u, expected"
-			    "1) -- please upgrade to a newer driver",
+			    " 1) -- please upgrade to a newer driver",
 			    version);
 		fw_unload_locked();
 		ret = -EFAULT;