From patchwork Tue Sep 23 08:27:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Schwarz X-Patchwork-Id: 4954301 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 28BBBBEEA5 for ; Tue, 23 Sep 2014 08:27:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B3A5D20145 for ; Tue, 23 Sep 2014 08:27:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FA5A2011D for ; Tue, 23 Sep 2014 08:27:52 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XWLRv-0004hK-6E; Tue, 23 Sep 2014 08:27:51 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XWLRs-0004PN-3L for linux-rockchip@lists.infradead.org; Tue, 23 Sep 2014 08:27:49 +0000 Received: from typ.localnet (xdsl-89-0-153-188.netcologne.de [89.0.153.188]) by mrelayeu.kundenserver.de (node=mreue103) with ESMTP (Nemesis) id 0MYLUv-1XjJyu2VGb-00V5F9; Tue, 23 Sep 2014 10:27:17 +0200 From: Max Schwarz To: linux-rockchip@lists.infradead.org Subject: [PATCH v5 RFC] i2c: rk3x: handle dynamic clock rate changes correctly Date: Tue, 23 Sep 2014 10:27:16 +0200 Message-ID: <5044926.7bKhNq8BYr@typ> User-Agent: KMail/4.13.3 (Linux/3.15.7-031507-generic; KDE/4.13.3; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V02:K0:KB9Naf1mEMlVW8+BKLnLN4GNwL4PpKzby+l9zx3CP6c IYeK8JiTtwcginWIOPEnuiYv0RDcAuwYD1oWsdDF55hoMeOEeX f7tD3tD+KGrbRngpTu570coubJ0M8RMZJGKwl1LvDWcnj3S/V2 kFa6xc7q8UfTIYs+tj2esWENJkRipOhCtRJNoiR8O8r58t31xY TC99yaSbKBwU1at5l0yElXFVxpvmFdR/5VSE70odM4LxaGZ1Je mOooVA6PdisF8qRn2OM2fTcCTZwpWaajs8cPrfTZJnYFLIswN6 mF0VCWD4OqRNa1HBZMj5/VvldJXd+YQ4tUh6g+UGWEqiFGBNA= = X-UI-Out-Filterresults: notjunk:1; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140923_012748_590257_6849E9A2 X-CRM114-Status: GOOD ( 23.07 ) X-Spam-Score: -0.2 (/) Cc: Huang Tao , addy ke , Doug Anderson , Heiko =?ISO-8859-1?Q?St=FCbner?= , Wolfram Sang X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The i2c input clock can change dynamically, e.g. on the RK3066 where pclk_i2c0 and pclk_i2c1 are connected to the armclk, which changes rate on cpu frequency scaling. Until now, we incorrectly called clk_get_rate() while holding the i2c->lock in rk3x_i2c_xfer() to adapt to clock rate changes. Thanks to Huang Tao for reporting this issue. Do it properly now using the clk notifier framework. The callback logic was taken from i2c-cadence.c. Signed-off-by: Max Schwarz Tested-by: Max Schwarz on RK3188 Tested-by: Doug Anderson on RK3288 (dynamic rate changes are untested!) --- This is based on Wolframs' i2c/for-current branch, since that includes the recent divisor fix by Addy Ke (b4a7bd7a38). Doug, I'm keeping your Tested-By since the changes should not touch the static clock case, but you might want to confirm that the Reviewed-By still stands. Changes since v4: - fixed a bug in rk3x_i2c_clk_notifier_cb() which would feed the input clock frequency as the desired SCL frequency into rk3x_i2c_set_scl_frequency(i2c, scl_rate). Rename & change to rk3x_i2c_adapt_div(i2c, clk_rate) to make things clear. - trimmed comment in rk3x_i2c_adapt_div() (sugg. by Doug Anderson) Changes since v3: - drop leftover write-only clk_freq variable (sugg. by Doug Anderson) Changes since v2: - allow rate changes which result in lower than desired SCL frequencies (sugg. by Doug Anderson) - simplified divider range checks (Doug Anderson) - removed duplicate clk_enable()/disable() (Doug Anderson) - added missing unregister in rk3x_i2c_remove() (Doug Anderson) Changes since v1: - make sure the i2c input clock is active during prescaler register write by explicitly enabling/disabling it in rk3x_i2c_set_scl_frequency(). Bug found by Addy Ke. It would still be awesome if someone with an RK3066 could test this. Heiko suggested using a script by Doug for stress-testing frequency changes: cd /sys/devices/system/cpu/cpu0/cpufreq echo userspace > scaling_governor unset FREQS read -a FREQS < scaling_available_frequencies RANDOM=$$$(date +%s) while true; do FREQ=${FREQS[$RANDOM % ${#FREQS[@]} ]} echo Now ${FREQ} echo ${FREQ} > scaling_setspeed done If you run some I2C transactions at the same time (e.g. using i2cget) that would be enough to confirm that everything still works. I'll also try to write a test driver for RK3188/RK3288 which can force i2c input clock rate changes. Cheers, Max drivers/i2c/busses/i2c-rk3x.c | 124 +++++++++++++++++++++++++++++++++++++++--- 1 file changed, 116 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c index 93cfc83..70d2dc3 100644 --- a/drivers/i2c/busses/i2c-rk3x.c +++ b/drivers/i2c/busses/i2c-rk3x.c @@ -97,6 +97,7 @@ struct rk3x_i2c { /* Hardware resources */ void __iomem *regs; struct clk *clk; + struct notifier_block clk_rate_nb; /* Settings */ unsigned int scl_frequency; @@ -428,18 +429,113 @@ out: return IRQ_HANDLED; } -static void rk3x_i2c_set_scl_rate(struct rk3x_i2c *i2c, unsigned long scl_rate) +/** + * Calculate divider value for desired SCL frequency + * + * @clk_rate: I2C input clock rate + * @scl_rate: Desired SCL rate + * @div: Divider output + * + * Return: 0 on success, -EINVAL on unreachable SCL rate. In that case + * a best-effort divider value is returned in div. + **/ +static int rk3x_i2c_calc_div(unsigned long clk_rate, unsigned long scl_rate, + unsigned int *div) { - unsigned long i2c_rate = clk_get_rate(i2c->clk); - unsigned int div; + unsigned long div_tmp; /* set DIV = DIVH = DIVL * SCL rate = (clk rate) / (8 * (DIVH + 1 + DIVL + 1)) * = (clk rate) / (16 * (DIV + 1)) */ - div = DIV_ROUND_UP(i2c_rate, scl_rate * 16) - 1; + div_tmp = DIV_ROUND_UP(clk_rate, scl_rate * 16) - 1; + + if (div_tmp > 0xFFFF) { + /* The input clock is too fast. Reject this rate change. */ + *div = 0xFFFF; + return -EINVAL; + } + + *div = div_tmp; + + return 0; +} + +/** + * Setup divider register for (changed) input clk rate + * + * @clk_rate: Input clock rate + **/ +static void rk3x_i2c_adapt_div(struct rk3x_i2c *i2c, unsigned long clk_rate) +{ + unsigned int div; + int ret; + + ret = rk3x_i2c_calc_div(clk_rate, i2c->scl_frequency, &div); + + WARN_ONCE(ret != 0, "Could not reach SCL freq %u", i2c->scl_frequency); + + /* + * Writing the register with halted clock crashes the system at least on + * RK3288. + */ + clk_enable(i2c->clk); i2c_writel(i2c, (div << 16) | (div & 0xffff), REG_CLKDIV); + clk_disable(i2c->clk); +} + +/** + * rk3x_i2c_clk_notifier_cb - Clock rate change callback + * @nb: Pointer to notifier block + * @event: Notification reason + * @data: Pointer to notification data object + * + * The callback checks whether a valid bus frequency can be generated after the + * change. If so, the change is acknowledged, otherwise the change is aborted. + * New dividers are written to the HW in the pre- or post change notification + * depending on the scaling direction. + * + * Code adapted from i2c-cadence.c. + * + * Return: NOTIFY_STOP if the rate change should be aborted, NOTIFY_OK + * to acknowedge the change, NOTIFY_DONE if the notification is + * considered irrelevant. + */ +static int rk3x_i2c_clk_notifier_cb(struct notifier_block *nb, unsigned long + event, void *data) +{ + struct clk_notifier_data *ndata = data; + struct rk3x_i2c *i2c = container_of(nb, struct rk3x_i2c, clk_rate_nb); + unsigned int div; + + switch (event) { + case PRE_RATE_CHANGE: + { + if (rk3x_i2c_calc_div(ndata->new_rate, i2c->scl_frequency, + &div) != 0) { + return NOTIFY_STOP; + } + + /* scale up */ + if (ndata->new_rate > ndata->old_rate) + rk3x_i2c_adapt_div(i2c, ndata->new_rate); + + return NOTIFY_OK; + } + case POST_RATE_CHANGE: + /* scale down */ + if (ndata->new_rate < ndata->old_rate) + rk3x_i2c_adapt_div(i2c, ndata->new_rate); + return NOTIFY_OK; + case ABORT_RATE_CHANGE: + /* scale up */ + if (ndata->new_rate > ndata->old_rate) + rk3x_i2c_adapt_div(i2c, ndata->old_rate); + return NOTIFY_OK; + default: + return NOTIFY_DONE; + } } /** @@ -536,9 +632,6 @@ static int rk3x_i2c_xfer(struct i2c_adapter *adap, clk_enable(i2c->clk); - /* The clock rate might have changed, so setup the divider again */ - rk3x_i2c_set_scl_rate(i2c, i2c->scl_frequency); - i2c->is_last_msg = false; /* @@ -624,6 +717,7 @@ static int rk3x_i2c_probe(struct platform_device *pdev) int bus_nr; u32 value; int irq; + unsigned long clk_rate; i2c = devm_kzalloc(&pdev->dev, sizeof(struct rk3x_i2c), GFP_KERNEL); if (!i2c) @@ -724,16 +818,28 @@ static int rk3x_i2c_probe(struct platform_device *pdev) return ret; } + i2c->clk_rate_nb.notifier_call = rk3x_i2c_clk_notifier_cb; + ret = clk_notifier_register(i2c->clk, &i2c->clk_rate_nb); + if (ret != 0) { + dev_err(&pdev->dev, "Unable to register clock notifier\n"); + goto err_clk; + } + + clk_rate = clk_get_rate(i2c->clk); + rk3x_i2c_adapt_div(i2c, clk_rate); + ret = i2c_add_adapter(&i2c->adap); if (ret < 0) { dev_err(&pdev->dev, "Could not register adapter\n"); - goto err_clk; + goto err_clk_notifier; } dev_info(&pdev->dev, "Initialized RK3xxx I2C bus at %p\n", i2c->regs); return 0; +err_clk_notifier: + clk_notifier_unregister(i2c->clk, &i2c->clk_rate_nb); err_clk: clk_unprepare(i2c->clk); return ret; @@ -744,6 +850,8 @@ static int rk3x_i2c_remove(struct platform_device *pdev) struct rk3x_i2c *i2c = platform_get_drvdata(pdev); i2c_del_adapter(&i2c->adap); + + clk_notifier_unregister(i2c->clk, &i2c->clk_rate_nb); clk_unprepare(i2c->clk); return 0;