diff mbox

sparse: Fix ioc type check

Message ID 8d1bffcadf496f52dc70063986684762344da771.1411633200.git.tgraf@suug.ch (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Thomas Graf Sept. 25, 2014, 8:20 a.m. UTC
Add missing exepcted error output for the test to pass.

Fixes: 42ebe41 "Add test case for the ioc type check"
Signed-off-by: Thomas Graf <tgraf@suug.ch>
---
 validation/ioc-typecheck.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Christopher Li Sept. 25, 2014, 12:10 p.m. UTC | #1
On Thu, Sep 25, 2014 at 4:20 PM, Thomas Graf <tgraf@suug.ch> wrote:
> Add missing exepcted error output for the test to pass.
>
> Fixes: 42ebe41 "Add test case for the ioc type check"
> Signed-off-by: Thomas Graf <tgraf@suug.ch>

No, this test case is some thing gcc can handle and sparse
can't. Instead of patching the test result, we need to fix sparse
to handle it correctly.

It is an open bug of sparse.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thomas Graf Sept. 25, 2014, 12:30 p.m. UTC | #2
On 09/25/14 at 08:10pm, Christopher Li wrote:
> No, this test case is some thing gcc can handle and sparse
> can't. Instead of patching the test result, we need to fix sparse
> to handle it correctly.
> 
> It is an open bug of sparse.

OK. This was not clear from the commit message.
Thanks for clarifying.
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/validation/ioc-typecheck.c b/validation/ioc-typecheck.c
index aa060f7..baa200a 100644
--- a/validation/ioc-typecheck.c
+++ b/validation/ioc-typecheck.c
@@ -13,5 +13,6 @@  static unsigned iocnrs[] = {
  * check-name: correct handling of _IOC_TYPECHECK
  *
  * check-error-start
+ioc-typecheck.c:10:21: error: bad integer constant expression
  * check-error-end
  */