[1/2] ASoC: Intel: byt-rt5640: Remove IN2N pin from DAPM route table
diff mbox

Message ID 1411999096-1867-1-git-send-email-jarkko.nikula@linux.intel.com
State Accepted
Commit ac06dd8df6e13591524f0e1bedf36af4ca0e967b
Headers show

Commit Message

Jarkko Nikula Sept. 29, 2014, 1:58 p.m. UTC
I tested couple byt-rt5640 based platforms and they have single-ended
headset microphone connection to IN2P only. I guess IN2N was either defined
by accident or some early platform had floating ground for headset. It's
better to remove IN2N and add a custom route for such a platform if needed.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
 sound/soc/intel/byt-rt5640.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Mark Brown Sept. 29, 2014, 6:45 p.m. UTC | #1
On Mon, Sep 29, 2014 at 04:58:15PM +0300, Jarkko Nikula wrote:
> I tested couple byt-rt5640 based platforms and they have single-ended
> headset microphone connection to IN2P only. I guess IN2N was either defined
> by accident or some early platform had floating ground for headset. It's
> better to remove IN2N and add a custom route for such a platform if needed.

Applied both, thanks.  I've got a feeling we may at some point want
infrastructure for the DMI stuff but that's not at all urgent.

Patch
diff mbox

diff --git a/sound/soc/intel/byt-rt5640.c b/sound/soc/intel/byt-rt5640.c
index 234a58de3c53..d6d8b19c22dc 100644
--- a/sound/soc/intel/byt-rt5640.c
+++ b/sound/soc/intel/byt-rt5640.c
@@ -36,7 +36,6 @@  static const struct snd_soc_dapm_widget byt_rt5640_widgets[] = {
 static const struct snd_soc_dapm_route byt_rt5640_audio_map[] = {
 	{"Headset Mic", NULL, "MICBIAS1"},
 	{"IN2P", NULL, "Headset Mic"},
-	{"IN2N", NULL, "Headset Mic"},
 	{"DMIC1", NULL, "Internal Mic"},
 	{"Headphone", NULL, "HPOL"},
 	{"Headphone", NULL, "HPOR"},