[v3,1/2] ASoC: fsl_ssi: Remove unneeded 'i2s-slave' property
diff mbox

Message ID 1412043930-15243-1-git-send-email-festevam@gmail.com
State Accepted
Commit ece1e4999606fc323aee96a1cdb9b7991c01dd09
Headers show

Commit Message

Fabio Estevam Sept. 30, 2014, 2:25 a.m. UTC
From: Fabio Estevam <fabio.estevam@freescale.com>

There is no need to use 'i2s-slave' property, since master/slave configuration
are passed via machine layer.

This change does not break existing users because they do check for slave
mode inside sound/soc/fsl/mpc8610_hpcd.c/p1022_ds.c/p1022_rdk.c

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Timur Tabi <timur@tabi.org>
---
Changes since v2:
- Added Timur's Ack and CC the alsa-list
Changes since v1:
- None

 sound/soc/fsl/fsl_ssi.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Mark Brown Sept. 30, 2014, 12:43 p.m. UTC | #1
On Mon, Sep 29, 2014 at 11:25:29PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> There is no need to use 'i2s-slave' property, since master/slave configuration
> are passed via machine layer.

Applied both, thanks.

Patch
diff mbox

diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 2fc3e66..0e7ce50 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -1285,9 +1285,6 @@  static int fsl_ssi_probe(struct platform_device *pdev)
 	if (sprop) {
 		if (!strcmp(sprop, "ac97-slave"))
 			ssi_private->dai_fmt = SND_SOC_DAIFMT_AC97;
-		else if (!strcmp(sprop, "i2s-slave"))
-			ssi_private->dai_fmt = SND_SOC_DAIFMT_I2S |
-				SND_SOC_DAIFMT_CBM_CFM;
 	}
 
 	ssi_private->use_dma = !of_property_read_bool(np,