spi: bcm53xx: add BCMA dependency
diff mbox

Message ID 3256402.M8e92DFkbg@wuerfel
State New, archived
Headers show

Commit Message

Arnd Bergmann Sept. 30, 2014, 12:09 p.m. UTC
The BCMA bus framework can be disabled on bcm53xx, which leads to a link
error when building the SPI driver:

drivers/built-in.o: In function `bcm53xxspi_module_init':
:(.init.text+0x76d4): undefined reference to `__bcma_driver_register'
drivers/built-in.o: In function `bcm53xxspi_module_exit':
:(.exit.text+0x10fe): undefined reference to `bcma_driver_unregister'

To avoid that, this adds an explicit dependency on BCMA. While we're
changing the dependencies, let's also add a COMPILE_TEST option, which
will of course not have any effect unless building on another machine
that has BCMA enabled.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 0fc6a323e19 ("spi: bcm53xx: driver for SPI controller on Broadcom bcma SoC")


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rafał Miłecki Sept. 30, 2014, 12:13 p.m. UTC | #1
On 30 September 2014 14:09, Arnd Bergmann <arnd@arndb.de> wrote:
> The BCMA bus framework can be disabled on bcm53xx, which leads to a link
> error when building the SPI driver:

You missed this one:
https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/commit/?h=for-next&id=933fc7b06ca62741fd5067edab13068d13b3cb35
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Arnd Bergmann Sept. 30, 2014, 12:15 p.m. UTC | #2
On Tuesday 30 September 2014 14:13:35 Rafa? Mi?ecki wrote:
> On 30 September 2014 14:09, Arnd Bergmann <arnd@arndb.de> wrote:
> > The BCMA bus framework can be disabled on bcm53xx, which leads to a link
> > error when building the SPI driver:
> 
> You missed this one:
> https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/commit/?h=for-next&id=933fc7b06ca62741fd5067edab13068d13b3cb35
> 

Right, I'm still catching up with last week's build regressions.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index bb7b5ec000d9..ababd27a4211 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -115,7 +115,8 @@  config SPI_AU1550
 
 config SPI_BCM53XX
 	tristate "Broadcom BCM53xx SPI controller"
-	depends on ARCH_BCM_5301X
+	depends on ARCH_BCM_5301X || COMPILE_TEST
+	depends on BCMA
 	help
           Enable support for the SPI controller on Broadcom BCM53xx ARM SoCs.