[OPW,kernel,0/2] staging: dgnc: Removed braces {} not necessary for single statement
diff mbox

Message ID 1412588626-5099-1-git-send-email-sarahjmi07@gmail.com
State New, archived
Headers show

Commit Message

Sarah Khan Oct. 6, 2014, 9:43 a.m. UTC
WARNING: Braces {} are not required for single statements
checkpatch.pl warning in dgnc_tty.c

Signed-off-by: Sarah Khan <sarahjmi07@gmail.com>
---
 drivers/staging/dgnc/dgnc_tty.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Julia Lawall Oct. 6, 2014, 5:45 a.m. UTC | #1
Your patch numbering seems wrong.  It should be 1/2 and 2/2.

julia

> @@ -1043,9 +1043,8 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
>  			ch->ch_bd->bd_ops->send_start_character(ch);
>  		}
>  		/* No FLOW */
> -		else {
> +		else 
>  			/* Nothing needed. */
> -		}

Does the result of this change compile?

julia

Patch
diff mbox

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 03c1506..3d2ae0b 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -1043,9 +1043,8 @@  void dgnc_check_queue_flow_control(struct channel_t *ch)
 			ch->ch_bd->bd_ops->send_start_character(ch);
 		}
 		/* No FLOW */
-		else {
+		else 
 			/* Nothing needed. */
-		}
 	}
 }