[OPW,kernel,06/10] staging: rtl8723au: core: Fix missing blank line warning.
diff mbox

Message ID 1412790434-14086-6-git-send-email-yeliztaneroglu@gmail.com
State New, archived
Headers show

Commit Message

Yeliz Taneroglu Oct. 8, 2014, 5:47 p.m. UTC
The following patch fixes the checkpatch.pl warning:

drivers/staging/rtl8723au/core/rtw_mlme_ext.c WARNING: Missing a blank line after declarations

Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
---
 drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Julia Lawall Oct. 8, 2014, 8 p.m. UTC | #1
On Wed, 8 Oct 2014, Yeliz Taneroglu wrote:

> The following patch fixes the checkpatch.pl warning:
> 
> drivers/staging/rtl8723au/core/rtw_mlme_ext.c WARNING: Missing a blank line after declarations
> 
> Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> index d2ec26a..fcf7cf9 100644
> --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> @@ -331,6 +331,7 @@ rtw_update_TSF(struct mlme_ext_priv *pmlmeext, struct ieee80211_mgmt *mgmt)
>  int rtw_ch_set_search_ch23a(struct rt_channel_info *ch_set, const u32 ch)
>  {
>  	int i;
> +
>  	for (i = 0; ch_set[i]. ChannelNum != 0; i++) {
>  		if (ch == ch_set[i].ChannelNum)
>  			break;
> @@ -1572,6 +1573,7 @@ OnAssocReq23a(struct rtw_adapter *padapter, struct recv_frame *precv_frame)
>  	pstat->uapsd_bk = 0;
>  	if (pmlmepriv->qos_option) {
>  		const u8 *end = pos + left;
> +
>  		p = pos;
>  
>  		for (;;) {
> @@ -2599,7 +2601,9 @@ static void issue_probersp(struct rtw_adapter *padapter, unsigned char *da,
>  		if (ssid_ie && cur_network->Ssid.ssid_len) {
>  			uint remainder_ielen;
>  			u8 *remainder_ie;
> +
>  			remainder_ie = ssid_ie + 2;
> +

No need to add a blank line here.

julia

>  			remainder_ielen = pframe - remainder_ie;
>  
>  			DBG_8723A_LEVEL(_drv_warning_, "%s(%s): "
> @@ -2860,6 +2864,7 @@ static void issue_auth(struct rtw_adapter *padapter, struct sta_info *psta,
>  	if (psta) { /*  for AP mode */
>  #ifdef CONFIG_8723AU_AP_MODE
>  		unsigned short val16;
> +
>  		ether_addr_copy(mgmt->da, psta->hwaddr);
>  		ether_addr_copy(mgmt->sa, myid(&padapter->eeprompriv));
>  		ether_addr_copy(mgmt->bssid, myid(&padapter->eeprompriv));
> @@ -3302,6 +3307,7 @@ static void issue_assocreq(struct rtw_adapter *padapter)
>  			    !memcmp(p + 2, WMM_OUI23A, 4) ||
>  			    !memcmp(p + 2, WPS_OUI23A, 4)) {
>  				u8 plen = p[1];
> +
>  				if (!padapter->registrypriv.wifi_spec) {
>  					/* Commented by Kurt 20110629 */
>  					/* In some older APs, WPS handshake */
> @@ -4064,6 +4070,7 @@ static void rtw_site_survey(struct rtw_adapter *padapter)
>  		if (ScanType == SCAN_ACTIVE) /* obey the channel plan setting... */
>  		{
>  			int i;
> +
>  			for (i = 0;i<RTW_SSID_SCAN_AMOUNT;i++) {
>  				if (pmlmeext->sitesurvey_res.ssid[i].ssid_len) {
>  					/* todo: to issue two probe req??? */
> @@ -4285,6 +4292,7 @@ static struct wlan_bssid_ex *collect_bss_info(struct rtw_adapter *padapter,
>  				     bssid->IELength);
>  		if (p && p[1] > 0) {
>  			struct ieee80211_ht_cap *pHT_caps;
> +
>  			pHT_caps = (struct ieee80211_ht_cap *)(p + 2);
>  
>  			if (pHT_caps->cap_info &
> @@ -4311,6 +4319,7 @@ static void start_create_ibss(struct rtw_adapter *padapter)
>  	struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
>  	struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
>  	struct wlan_bssid_ex *pnetwork = &pmlmeinfo->network;
> +
>  	pmlmeext->cur_channel = (u8)pnetwork->DSConfig;
>  	pmlmeinfo->bcn_interval = pnetwork->beacon_interval;
>  
> -- 
> 1.8.3.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

Patch
diff mbox

diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index d2ec26a..fcf7cf9 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
@@ -331,6 +331,7 @@  rtw_update_TSF(struct mlme_ext_priv *pmlmeext, struct ieee80211_mgmt *mgmt)
 int rtw_ch_set_search_ch23a(struct rt_channel_info *ch_set, const u32 ch)
 {
 	int i;
+
 	for (i = 0; ch_set[i]. ChannelNum != 0; i++) {
 		if (ch == ch_set[i].ChannelNum)
 			break;
@@ -1572,6 +1573,7 @@  OnAssocReq23a(struct rtw_adapter *padapter, struct recv_frame *precv_frame)
 	pstat->uapsd_bk = 0;
 	if (pmlmepriv->qos_option) {
 		const u8 *end = pos + left;
+
 		p = pos;
 
 		for (;;) {
@@ -2599,7 +2601,9 @@  static void issue_probersp(struct rtw_adapter *padapter, unsigned char *da,
 		if (ssid_ie && cur_network->Ssid.ssid_len) {
 			uint remainder_ielen;
 			u8 *remainder_ie;
+
 			remainder_ie = ssid_ie + 2;
+
 			remainder_ielen = pframe - remainder_ie;
 
 			DBG_8723A_LEVEL(_drv_warning_, "%s(%s): "
@@ -2860,6 +2864,7 @@  static void issue_auth(struct rtw_adapter *padapter, struct sta_info *psta,
 	if (psta) { /*  for AP mode */
 #ifdef CONFIG_8723AU_AP_MODE
 		unsigned short val16;
+
 		ether_addr_copy(mgmt->da, psta->hwaddr);
 		ether_addr_copy(mgmt->sa, myid(&padapter->eeprompriv));
 		ether_addr_copy(mgmt->bssid, myid(&padapter->eeprompriv));
@@ -3302,6 +3307,7 @@  static void issue_assocreq(struct rtw_adapter *padapter)
 			    !memcmp(p + 2, WMM_OUI23A, 4) ||
 			    !memcmp(p + 2, WPS_OUI23A, 4)) {
 				u8 plen = p[1];
+
 				if (!padapter->registrypriv.wifi_spec) {
 					/* Commented by Kurt 20110629 */
 					/* In some older APs, WPS handshake */
@@ -4064,6 +4070,7 @@  static void rtw_site_survey(struct rtw_adapter *padapter)
 		if (ScanType == SCAN_ACTIVE) /* obey the channel plan setting... */
 		{
 			int i;
+
 			for (i = 0;i<RTW_SSID_SCAN_AMOUNT;i++) {
 				if (pmlmeext->sitesurvey_res.ssid[i].ssid_len) {
 					/* todo: to issue two probe req??? */
@@ -4285,6 +4292,7 @@  static struct wlan_bssid_ex *collect_bss_info(struct rtw_adapter *padapter,
 				     bssid->IELength);
 		if (p && p[1] > 0) {
 			struct ieee80211_ht_cap *pHT_caps;
+
 			pHT_caps = (struct ieee80211_ht_cap *)(p + 2);
 
 			if (pHT_caps->cap_info &
@@ -4311,6 +4319,7 @@  static void start_create_ibss(struct rtw_adapter *padapter)
 	struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
 	struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
 	struct wlan_bssid_ex *pnetwork = &pmlmeinfo->network;
+
 	pmlmeext->cur_channel = (u8)pnetwork->DSConfig;
 	pmlmeinfo->bcn_interval = pnetwork->beacon_interval;