[v5,6/6] ARM: dts: add RK3288 suspend support
diff mbox

Message ID 1414417650-19402-7-git-send-email-zyw@rock-chips.com
State New, archived
Headers show

Commit Message

Chris Zhong Oct. 27, 2014, 1:47 p.m. UTC
add pmu_intmem node for suspend, add global_pwroff pinctrl.
The pmu_intmem is used to store the resume code.
global_pwroff is held low level at work, it would be pull to high
when entering suspend. reference this in the board DTS file since
some boards need it.

Signed-off-by: Tony Xie <xxx@rock-chips.com>
Signed-off-by: Chris Zhong <zyw@rock-chips.com>

---

Changes in v5:
- change size to 4k

Changes in v4: None
Changes in v3: None
Changes in v2:
- put "rockchip,rk3288-pmu-sram" to first

 arch/arm/boot/dts/rk3288.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Doug Anderson Oct. 27, 2014, 5:48 p.m. UTC | #1
Chris,

On Mon, Oct 27, 2014 at 6:47 AM, Chris Zhong <zyw@rock-chips.com> wrote:
> add pmu_intmem node for suspend, add global_pwroff pinctrl.
> The pmu_intmem is used to store the resume code.
> global_pwroff is held low level at work, it would be pull to high
> when entering suspend. reference this in the board DTS file since
> some boards need it.
>
> Signed-off-by: Tony Xie <xxx@rock-chips.com>
> Signed-off-by: Chris Zhong <zyw@rock-chips.com>

Reviewed-by: Doug Anderson <dianders@chromium.org>
Tested-by: Doug Anderson <dianders@chromium.org>
Heiko Stübner Oct. 28, 2014, 2:48 p.m. UTC | #2
Am Montag, 27. Oktober 2014, 21:47:30 schrieb Chris Zhong:
> add pmu_intmem node for suspend, add global_pwroff pinctrl.
> The pmu_intmem is used to store the resume code.
> global_pwroff is held low level at work, it would be pull to high
> when entering suspend. reference this in the board DTS file since
> some boards need it.
> 
> Signed-off-by: Tony Xie <xxx@rock-chips.com>
> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
> 
> ---
> 
> Changes in v5:
> - change size to 4k
> 
> Changes in v4: None
> Changes in v3: None
> Changes in v2:
> - put "rockchip,rk3288-pmu-sram" to first
> 
>  arch/arm/boot/dts/rk3288.dtsi |   11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 874e66d..00dd9d7 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -439,6 +439,11 @@
>  		status = "disabled";
>  	};
> 
> +	pmu_intmem@ff720000 {

the node name should be a generic descriptor of what it is, so I guess 
something like

	sram@ff720000

would be a better choice.


> +		compatible = "rockchip,rk3288-pmu-sram", "mmio-sram";
> +		reg = <0xff720000 0x1000>;
> +	};
> +
>  	pmu: power-management@ff730000 {
>  		compatible = "rockchip,rk3288-pmu", "syscon";
>  		reg = <0xff730000 0x100>;
> @@ -634,6 +639,12 @@
>  			bias-disable;
>  		};
> 
> +		sleep {
> +			global_pwroff: global-pwroff {

shouldn't this global_pwroff pinsetting also be used somewhere?


> +				rockchip,pins = <0 0 RK_FUNC_1 &pcfg_pull_none>;
> +			};
> +		};
> +
>  		i2c0 {
>  			i2c0_xfer: i2c0-xfer {
>  				rockchip,pins = <0 15 RK_FUNC_1 &pcfg_pull_none>,


Heiko
Doug Anderson Oct. 28, 2014, 3:16 p.m. UTC | #3
Heiko,

On Tue, Oct 28, 2014 at 7:48 AM, Heiko Stübner <heiko@sntech.de> wrote:
>> +             sleep {
>> +                     global_pwroff: global-pwroff {
>
> shouldn't this global_pwroff pinsetting also be used somewhere?

It's intended to be referenced in board files.  Earlier in the review
of this patch I asked Chris to mention this in the CL desc.  That's
why he added:

>> global_pwroff is held low level at work, it would be pull to high
>> when entering suspend. reference this in the board DTS file since
>> some boards need it.

Patch
diff mbox

diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 874e66d..00dd9d7 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -439,6 +439,11 @@ 
 		status = "disabled";
 	};
 
+	pmu_intmem@ff720000 {
+		compatible = "rockchip,rk3288-pmu-sram", "mmio-sram";
+		reg = <0xff720000 0x1000>;
+	};
+
 	pmu: power-management@ff730000 {
 		compatible = "rockchip,rk3288-pmu", "syscon";
 		reg = <0xff730000 0x100>;
@@ -634,6 +639,12 @@ 
 			bias-disable;
 		};
 
+		sleep {
+			global_pwroff: global-pwroff {
+				rockchip,pins = <0 0 RK_FUNC_1 &pcfg_pull_none>;
+			};
+		};
+
 		i2c0 {
 			i2c0_xfer: i2c0-xfer {
 				rockchip,pins = <0 15 RK_FUNC_1 &pcfg_pull_none>,