[OPW,kernel,4/5] staging: rtl8723au: include: Change function return type
diff mbox

Message ID 1414545296-23986-5-git-send-email-roberta.dobrescu@gmail.com
State New, archived
Headers show

Commit Message

Roberta Dobrescu Oct. 29, 2014, 1:14 a.m. UTC
This patch changes the return type of rtw_init_evt_priv23a from u32
to int, since this function returns 0 in case of success or an
appropriate negative value in case of failure.

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
---
 drivers/staging/rtl8723au/include/rtw_cmd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg KH Oct. 29, 2014, 1:53 a.m. UTC | #1
On Wed, Oct 29, 2014 at 03:14:55AM +0200, Roberta Dobrescu wrote:
> This patch changes the return type of rtw_init_evt_priv23a from u32
> to int, since this function returns 0 in case of success or an
> appropriate negative value in case of failure.
> 
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
> ---
>  drivers/staging/rtl8723au/include/rtw_cmd.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723au/include/rtw_cmd.h b/drivers/staging/rtl8723au/include/rtw_cmd.h
> index 8ffe5de..f948037 100644
> --- a/drivers/staging/rtl8723au/include/rtw_cmd.h
> +++ b/drivers/staging/rtl8723au/include/rtw_cmd.h
> @@ -98,7 +98,7 @@ int rtw_cmd_thread23a(void *context);
>  
>  int rtw_init_cmd_priv23a(struct cmd_priv *pcmdpriv);
>  
> -u32 rtw_init_evt_priv23a (struct evt_priv *pevtpriv);
> +int rtw_init_evt_priv23a(struct evt_priv *pevtpriv);

Doesn't this change cause a build warning/error?  You have to change the
actual function at the same time, in the same patch.

thanks,

greg k-h
Roberta Dobrescu Oct. 29, 2014, 8 a.m. UTC | #2
On 29.10.2014 03:53, Greg KH wrote:
> On Wed, Oct 29, 2014 at 03:14:55AM +0200, Roberta Dobrescu wrote:
>> This patch changes the return type of rtw_init_evt_priv23a from u32
>> to int, since this function returns 0 in case of success or an
>> appropriate negative value in case of failure.
>>
>> Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
>> ---
>>   drivers/staging/rtl8723au/include/rtw_cmd.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8723au/include/rtw_cmd.h b/drivers/staging/rtl8723au/include/rtw_cmd.h
>> index 8ffe5de..f948037 100644
>> --- a/drivers/staging/rtl8723au/include/rtw_cmd.h
>> +++ b/drivers/staging/rtl8723au/include/rtw_cmd.h
>> @@ -98,7 +98,7 @@ int rtw_cmd_thread23a(void *context);
>>
>>   int rtw_init_cmd_priv23a(struct cmd_priv *pcmdpriv);
>>
>> -u32 rtw_init_evt_priv23a (struct evt_priv *pevtpriv);
>> +int rtw_init_evt_priv23a(struct evt_priv *pevtpriv);
>
> Doesn't this change cause a build warning/error?  You have to change the
> actual function at the same time, in the same patch.

I actually changed the function, but it got in the wrong patch, the one
with the modifications from the entire core directory. I'll move that
here.

Thanks,
Roberta

Patch
diff mbox

diff --git a/drivers/staging/rtl8723au/include/rtw_cmd.h b/drivers/staging/rtl8723au/include/rtw_cmd.h
index 8ffe5de..f948037 100644
--- a/drivers/staging/rtl8723au/include/rtw_cmd.h
+++ b/drivers/staging/rtl8723au/include/rtw_cmd.h
@@ -98,7 +98,7 @@  int rtw_cmd_thread23a(void *context);
 
 int rtw_init_cmd_priv23a(struct cmd_priv *pcmdpriv);
 
-u32 rtw_init_evt_priv23a (struct evt_priv *pevtpriv);
+int rtw_init_evt_priv23a(struct evt_priv *pevtpriv);
 void rtw_free_evt_priv23a (struct evt_priv *pevtpriv);
 void rtw_cmd_clr_isr23a(struct cmd_priv *pcmdpriv);
 void rtw_evt_notify_isr(struct evt_priv *pevtpriv);