[-,hda,1/1] Add ultra dock support for Thinkpad X240.
diff mbox

Message ID CAE36HYx9LD+=1AXiwvEJqqFjtDcm-brLOpgjaaEwGd8wWwCQBw@mail.gmail.com
State Accepted
Delegated to: Takashi Iwai
Headers show

Commit Message

Lukas Bossard Oct. 29, 2014, 5:31 p.m. UTC
Adding ultra doch support for Lenovo Thinkpad X240 (17aa:2214).

Signed-off-by: Lukas Bossard <mr.bobukas@gmail.com>

ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
     SND_PCI_QUIRK(0x17aa, 0x3978, "IdeaPad Y410P", ALC269_FIXUP_NO_SHUTUP),

Comments

Takashi Iwai Oct. 30, 2014, 7:09 a.m. UTC | #1
At Wed, 29 Oct 2014 18:31:07 +0100,
Lukas wrote:
> 
> Adding ultra doch support for Lenovo Thinkpad X240 (17aa:2214).
> 
> Signed-off-by: Lukas Bossard <mr.bobukas@gmail.com>

As your MUA broke the white spaces, the patch was broken and couldn't
be applied cleanly as is, so I applied manually.  Also, the duplicated
entry (17aa:2214) just below your addition has to be removed.

Last but not least, your From address doesn't match with
Signed-off-by.  They have to be identical.  If your MUA setup can't be
changed, you can add "From:" line in the patch itself to override.

In anyway, the patch was applied now with these fixes.  Please avoid
them at the next time.  Thanks!


Takashi

> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 34b7bdb..528bb2d 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4803,6 +4803,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>      SND_PCI_QUIRK(0x17aa, 0x220e, "Thinkpad T440p", ALC292_FIXUP_TPT440_DOCK),
>      SND_PCI_QUIRK(0x17aa, 0x2210, "Thinkpad T540p", ALC292_FIXUP_TPT440_DOCK),
>      SND_PCI_QUIRK(0x17aa, 0x2212, "Thinkpad T440", ALC292_FIXUP_TPT440_DOCK),
> +    SND_PCI_QUIRK(0x17aa, 0x2214, "Thinkpad X240", ALC292_FIXUP_TPT440_DOCK),
>      SND_PCI_QUIRK(0x17aa, 0x2214, "Thinkpad",
> ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>      SND_PCI_QUIRK(0x17aa, 0x2215, "Thinkpad",
> ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>      SND_PCI_QUIRK(0x17aa, 0x3978, "IdeaPad Y410P", ALC269_FIXUP_NO_SHUTUP),
> -- 
> 2.1.0
>

Patch
diff mbox

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 34b7bdb..528bb2d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4803,6 +4803,7 @@  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
     SND_PCI_QUIRK(0x17aa, 0x220e, "Thinkpad T440p", ALC292_FIXUP_TPT440_DOCK),
     SND_PCI_QUIRK(0x17aa, 0x2210, "Thinkpad T540p", ALC292_FIXUP_TPT440_DOCK),
     SND_PCI_QUIRK(0x17aa, 0x2212, "Thinkpad T440", ALC292_FIXUP_TPT440_DOCK),
+    SND_PCI_QUIRK(0x17aa, 0x2214, "Thinkpad X240", ALC292_FIXUP_TPT440_DOCK),
     SND_PCI_QUIRK(0x17aa, 0x2214, "Thinkpad",
ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
     SND_PCI_QUIRK(0x17aa, 0x2215, "Thinkpad",