[OPW,kernel] fs: Stop the build system recursing into the /exofs directory.
diff mbox

Message ID 20141030070120.GA5044@heena-HP-Compaq-8200-Elite-MT-PC
State New, archived
Headers show

Commit Message

Heena Sirwani Oct. 30, 2014, 7:01 a.m. UTC
The following patch stops the build system from recursing into the exofs
directory as it has an empty built-in.o file. This makes the build faster and
makes it easier to identify which code gets built in.

Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
---
 fs/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arnd Bergmann Oct. 30, 2014, 7:06 a.m. UTC | #1
On Thursday 30 October 2014 12:31:20 Heena Sirwani wrote:
> @@ -121,7 +121,7 @@ obj-$(CONFIG_OCFS2_FS)              += ocfs2/
>  obj-$(CONFIG_BTRFS_FS)         += btrfs/
>  obj-$(CONFIG_GFS2_FS)           += gfs2/
>  obj-$(CONFIG_F2FS_FS)          += f2fs/
> -obj-y                          += exofs/ # Multiple modules
> +obj-$(CONFIG_EXOFS_FS)         += exofs/ # Multiple modules
>  obj-$(CONFIG_CEPH_FS)          += ceph/
>  obj-$(CONFIG_PSTORE)           += pstore/
>  obj-$(CONFIG_EFIVAR_FS)                += efivarfs/
> 

What the "Multiple modules" comment is trying to tell you is that there
are multiple modules inside of fs/exofs. If CONFIG_ORE is set but
CONFIG_EXOFS_FS is not set, you still need to enter that directory.

	Arnd
Heena Sirwani Oct. 30, 2014, 7:10 a.m. UTC | #2
On Thu, Oct 30, 2014 at 12:36 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> On Thursday 30 October 2014 12:31:20 Heena Sirwani wrote:
> > @@ -121,7 +121,7 @@ obj-$(CONFIG_OCFS2_FS)              += ocfs2/
> >  obj-$(CONFIG_BTRFS_FS)         += btrfs/
> >  obj-$(CONFIG_GFS2_FS)           += gfs2/
> >  obj-$(CONFIG_F2FS_FS)          += f2fs/
> > -obj-y                          += exofs/ # Multiple modules
> > +obj-$(CONFIG_EXOFS_FS)         += exofs/ # Multiple modules
> >  obj-$(CONFIG_CEPH_FS)          += ceph/
> >  obj-$(CONFIG_PSTORE)           += pstore/
> >  obj-$(CONFIG_EFIVAR_FS)                += efivarfs/
> >
>
> What the "Multiple modules" comment is trying to tell you is that there
> are multiple modules inside of fs/exofs. If CONFIG_ORE is set but
> CONFIG_EXOFS_FS is not set, you still need to enter that directory.
>

Ok. I was initially doubtful about it too. Thanks :) I'll revert that.

>
>         Arnd
>

Patch
diff mbox

diff --git a/fs/Makefile b/fs/Makefile
index 90c8852..f5eca8e 100644
--- a/fs/Makefile
+++ b/fs/Makefile
@@ -121,7 +121,7 @@  obj-$(CONFIG_OCFS2_FS)		+= ocfs2/
 obj-$(CONFIG_BTRFS_FS)		+= btrfs/
 obj-$(CONFIG_GFS2_FS)           += gfs2/
 obj-$(CONFIG_F2FS_FS)		+= f2fs/
-obj-y				+= exofs/ # Multiple modules
+obj-$(CONFIG_EXOFS_FS)		+= exofs/ # Multiple modules
 obj-$(CONFIG_CEPH_FS)		+= ceph/
 obj-$(CONFIG_PSTORE)		+= pstore/
 obj-$(CONFIG_EFIVAR_FS)		+= efivarfs/