[OPW,kernel] Staging: ft1000: ft1000_usb: fixed checkpatch warnings
diff mbox

Message ID 1414691649-20420-1-git-send-email-suryaseetharaman.9@gmail.com
State New, archived
Headers show

Commit Message

tssurya Oct. 30, 2014, 5:54 p.m. UTC
removed the following warnings:-
WARNING: void function return statements are not generally useful
WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
---
 drivers/staging/ft1000/ft1000-usb/ft1000_usb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Greg KH Oct. 30, 2014, 8:17 p.m. UTC | #1
On Thu, Oct 30, 2014 at 11:24:09PM +0530, Surya Seetharaman wrote:
> removed the following warnings:-
> WARNING: void function return statements are not generally useful
> WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
> 
> Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
> ---
>  drivers/staging/ft1000/ft1000-usb/ft1000_usb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
> index cc740c9..608eca0 100644
> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
> @@ -41,7 +41,7 @@ static int ft1000_poll_thread(void *arg)
>  	int ret;
>  
>  	while (!kthread_should_stop()) {
> -		msleep(10);
> +		usleep_range(1000, 3000);
>  		if (!gPollingfailed) {
>  			ret = ft1000_poll(arg);
>  			if (ret != 0) {
> @@ -247,7 +247,6 @@ static void ft1000_disconnect(struct usb_interface *interface)
>  	}
>  	kfree(pFileStart);
>  
> -	return;
>  }
>  
>  static struct usb_driver ft1000_usb_driver = {

This patch doesn't apply to my tree :(

Patch
diff mbox

diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
index cc740c9..608eca0 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
@@ -41,7 +41,7 @@  static int ft1000_poll_thread(void *arg)
 	int ret;
 
 	while (!kthread_should_stop()) {
-		msleep(10);
+		usleep_range(1000, 3000);
 		if (!gPollingfailed) {
 			ret = ft1000_poll(arg);
 			if (ret != 0) {
@@ -247,7 +247,6 @@  static void ft1000_disconnect(struct usb_interface *interface)
 	}
 	kfree(pFileStart);
 
-	return;
 }
 
 static struct usb_driver ft1000_usb_driver = {