[OPW,kernel] Staging: rtl8192e: rtllib_rx: Adding parenthesis to macros with complex values
diff mbox

Message ID 1414697401-3952-1-git-send-email-anuv.1994@gmail.com
State New, archived
Headers show

Commit Message

anuvazhayil Oct. 30, 2014, 7:30 p.m. UTC
Fix the checkpatch.pl ERROR: Macros with complex values should be enclosed in parentheses in rtllib_rx.c file

Signed-off-by: anuvazhayil <anuv.1994@gmail.com>
---
 drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg KH Oct. 30, 2014, 7:43 p.m. UTC | #1
On Fri, Oct 31, 2014 at 01:00:01AM +0530, anuvazhayil wrote:
> Fix the checkpatch.pl ERROR: Macros with complex values should be enclosed in parentheses in rtllib_rx.c file

Please properly line-wrap your text here.

> 
> Signed-off-by: anuvazhayil <anuv.1994@gmail.com>

I need a "real and full" name for a signed-off-by line.  See
Documentation/SubmittingPatches for what this means.


> ---
>  drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index 0c0f196..6ef55b8 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -1697,7 +1697,7 @@ static int rtllib_parse_qos_info_param_IE(struct rtllib_info_element
>  	return rc;
>  }
>  
> -#define MFIE_STRING(x) case MFIE_TYPE_ ##x: return #x
> +#define MFIE_STRING(x) (case MFIE_TYPE_ ##x: return #x)
>  
>  static const char *get_info_element_string(u16 id)
>  {

Does this even build?

thanks,

greg k-h

Patch
diff mbox

diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 0c0f196..6ef55b8 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -1697,7 +1697,7 @@  static int rtllib_parse_qos_info_param_IE(struct rtllib_info_element
 	return rc;
 }
 
-#define MFIE_STRING(x) case MFIE_TYPE_ ##x: return #x
+#define MFIE_STRING(x) (case MFIE_TYPE_ ##x: return #x)
 
 static const char *get_info_element_string(u16 id)
 {