mountstats: Don't display retrans stats unless there are re-xmits
diff mbox

Message ID 20141031211917.13278.61844.stgit@manet.1015granger.net
State New, archived
Headers show

Commit Message

Chuck Lever Oct. 31, 2014, 9:19 p.m. UTC
Clean up display of RPC statistics by omitting retransmit statistics
when there have been no retransmissions.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 tools/mountstats/mountstats.py |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Steve Dickson Nov. 4, 2014, 7:04 p.m. UTC | #1
On 10/31/2014 05:19 PM, Chuck Lever wrote:
> Clean up display of RPC statistics by omitting retransmit statistics
> when there have been no retransmissions.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Committed... 

steved.

> ---
>  tools/mountstats/mountstats.py |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
> index 1fb3e2f..9a6ec43 100644
> --- a/tools/mountstats/mountstats.py
> +++ b/tools/mountstats/mountstats.py
> @@ -272,8 +272,11 @@ class DeviceData:
>                  print('%s:' % op)
>                  print('\t%d ops (%d%%)' % \
>                      (count, ((count * 100) / sends)), end=' ')
> -                print('\t%d retrans (%d%%)' % (retrans, ((retrans * 100) / count)), end=' ')
> -                print('\t%d major timeouts' % stats[2])
> +                if retrans != 0:
> +                    print('\t%d retrans (%d%%)' % (retrans, ((retrans * 100) / count)), end=' ')
> +                    print('\t%d major timeouts' % stats[2])
> +                else:
> +                    print('')
>                  print('\tavg bytes sent per op: %d\tavg bytes received per op: %d' % \
>                      (stats[3] / count, stats[4] / count))
>                  print('\tbacklog wait: %f' % (float(stats[5]) / count), end=' ')
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
index 1fb3e2f..9a6ec43 100644
--- a/tools/mountstats/mountstats.py
+++ b/tools/mountstats/mountstats.py
@@ -272,8 +272,11 @@  class DeviceData:
                 print('%s:' % op)
                 print('\t%d ops (%d%%)' % \
                     (count, ((count * 100) / sends)), end=' ')
-                print('\t%d retrans (%d%%)' % (retrans, ((retrans * 100) / count)), end=' ')
-                print('\t%d major timeouts' % stats[2])
+                if retrans != 0:
+                    print('\t%d retrans (%d%%)' % (retrans, ((retrans * 100) / count)), end=' ')
+                    print('\t%d major timeouts' % stats[2])
+                else:
+                    print('')
                 print('\tavg bytes sent per op: %d\tavg bytes received per op: %d' % \
                     (stats[3] / count, stats[4] / count))
                 print('\tbacklog wait: %f' % (float(stats[5]) / count), end=' ')