| Message ID | 1415025649-8119-8-git-send-email-javier.martinez@collabora.co.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ecea7484d2f76da1ce1eacdc7c25df08dab6fe78 |
| Headers | show |
On Mon, Nov 03, 2014 at 03:40:42PM +0100, Javier Martinez Canillas wrote: > The struct of_regulator_match is declared as a non-static local variable > so the structure members are not auto-initialized. Applied, thanks.
diff --git a/drivers/regulator/max77802.c b/drivers/regulator/max77802.c index a0d1462..d10c605 100644 --- a/drivers/regulator/max77802.c +++ b/drivers/regulator/max77802.c @@ -520,7 +520,7 @@ static int max77802_pmic_dt_parse_pdata(struct platform_device *pdev, struct max77686_dev *iodev = dev_get_drvdata(pdev->dev.parent); struct device_node *pmic_np, *regulators_np; struct max77686_regulator_data *rdata; - struct of_regulator_match rmatch; + struct of_regulator_match rmatch = { }; unsigned int i; pmic_np = iodev->dev->of_node;
The struct of_regulator_match is declared as a non-static local variable so the structure members are not auto-initialized. Initialize the struct at declaration time to avoid the structure members values to be indeterminate and have sane defaults instead. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- drivers/regulator/max77802.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)