| Message ID | 1415205892-5553-1-git-send-email-afaerber@suse.de (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Wed, Nov 05, 2014 at 05:44:52PM +0100, Andreas Färber wrote:
> This enables the snd_soc_snow module to be auto-loaded.
Applied, thanks.
Am 05.11.2014 um 18:09 schrieb Mark Brown: > On Wed, Nov 05, 2014 at 05:44:52PM +0100, Andreas Färber wrote: >> This enables the snd_soc_snow module to be auto-loaded. > > Applied, thanks. Thanks. I notice you dropped my Fixes: line that SubmittingPatches asks for. When do I need it and when should I leave it out? I thought it tells GregKH more precisely which stable branches are affected for backports than just a CC. Regards, Andreas
On Wed, Nov 05, 2014 at 07:11:06PM +0100, Andreas Färber wrote: > Am 05.11.2014 um 18:09 schrieb Mark Brown: > > On Wed, Nov 05, 2014 at 05:44:52PM +0100, Andreas Färber wrote: > >> This enables the snd_soc_snow module to be auto-loaded. > > Applied, thanks. > Thanks. I notice you dropped my Fixes: line that SubmittingPatches asks > for. When do I need it and when should I leave it out? I thought it > tells GregKH more precisely which stable branches are affected for > backports than just a CC. It's not really adding anything if it's just identifying the patch that created the file in the first place and what actually happened here is that I applied it without the tag then later went back and decided to add a stable Cc since it was probably worth that.
diff --git a/sound/soc/samsung/snow.c b/sound/soc/samsung/snow.c index 0acf5d0eed53..72118a77dd5b 100644 --- a/sound/soc/samsung/snow.c +++ b/sound/soc/samsung/snow.c @@ -110,6 +110,7 @@ static const struct of_device_id snow_of_match[] = { { .compatible = "google,snow-audio-max98095", }, {}, }; +MODULE_DEVICE_TABLE(of, snow_of_match); static struct platform_driver snow_driver = { .driver = {
This enables the snd_soc_snow module to be auto-loaded. Fixes: da5993df2374 ("ASoC: samsung: Add sound card driver for Snow board") Signed-off-by: Andreas Färber <afaerber@suse.de> --- Tested using patches for Spring, but should apply to Snow/Peach-pi equally. Rebased onto sound.git for-next branch. sound/soc/samsung/snow.c | 1 + 1 file changed, 1 insertion(+)