| Message ID | 1415621455-10468-3-git-send-email-james.hartley@imgtec.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
Hi James, On Mon, Nov 10, 2014 at 4:10 AM, James Hartley <james.hartley@imgtec.com> wrote: > Signed-off-by: James Hartley <james.hartley@imgtec.com> A brief commit message describing the hardware and where it's found would be nice. > diff --git a/Documentation/devicetree/bindings/crypto/img-hash.txt b/Documentation/devicetree/bindings/crypto/img-hash.txt > @@ -0,0 +1,28 @@ > +* Imagination Technologies Ltd. Hash Accelerator > + > +The hash accelerator provides hardware hashing acceleration for > +SHA1, SHA224, SHA256 and MD5 hashes > + > +Required properties: > + > +- compatible : "img,img-hash-accelerator-rev1" I know I mentioned in the internal review that it would be good to have some sort of version indicator, but it looks like from the TRM that the version is probable (CR_HASH_CORE_REV). If we expect probing for the revision number to be sufficient, then perhaps "rev1" can be dropped? Also, the second "img" is redundant. > +- reg : Offset and length of the register set for the module, and the DMA port > +- interrupts : The designated IRQ line for the hashing module. > +- dmas : DMA specifier as per Documentation/devicetree/bindings/dma/dma.txt > +- dma-names : Should be "tx" > +- bus-addr : The bus address for the input data for hashing block I think this can be dropped. This is the same as the second "reg" entry above, is it not? -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
SGkgQW5kcmV3DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogYWJyZXN0 aWNAZ29vZ2xlLmNvbSBbbWFpbHRvOmFicmVzdGljQGdvb2dsZS5jb21dIE9uIEJlaGFsZiBPZg0K PiBBbmRyZXcgQnJlc3RpY2tlcg0KPiBTZW50OiAxMCBOb3ZlbWJlciAyMDE0IDE3OjMwDQo+IFRv OiBKYW1lcyBIYXJ0bGV5DQo+IENjOiBoZXJiZXJ0QGdvbmRvci5hcGFuYS5vcmcuYXU7IGRhdmVt QGRhdmVtbG9mdC5uZXQ7IEdyYW50IExpa2VseTsgUm9iDQo+IEhlcnJpbmc7IGFrcG1AbGludXgt Zm91bmRhdGlvbi5vcmc7IEdyZWcgS3JvYWgtSGFydG1hbjsNCj4gam9lQHBlcmNoZXMuY29tOyBt Y2hlaGFiQG9zZy5zYW1zdW5nLmNvbTsgY3JvcGVAaWtpLmZpOw0KPiBqZzEuaGFuQHNhbXN1bmcu Y29tOyBsaW51eC1jcnlwdG9Admdlci5rZXJuZWwub3JnOw0KPiBkZXZpY2V0cmVlQHZnZXIua2Vy bmVsLm9yZzsgUGF3ZWwgTW9sbDsgTWFyayBSdXRsYW5kOyBJYW4gQ2FtcGJlbGw7IEt1bWFyDQo+ IEdhbGE7IEV6ZXF1aWVsIEdhcmNpYQ0KPiBTdWJqZWN0OiBSZTogW1BBVENIIDIvMl0gRG9jdW1l bnRhdGlvbjogY3J5cHRvOiBBZGQgRFQgYmluZGluZyBpbmZvIGZvciB0aGUNCj4gaW1nIGh3IGhh c2ggYWNjZWxlcmF0b3INCj4gDQo+IEhpIEphbWVzLA0KPiANCj4gT24gTW9uLCBOb3YgMTAsIDIw MTQgYXQgNDoxMCBBTSwgSmFtZXMgSGFydGxleQ0KPiA8amFtZXMuaGFydGxleUBpbWd0ZWMuY29t PiB3cm90ZToNCj4gPiBTaWduZWQtb2ZmLWJ5OiBKYW1lcyBIYXJ0bGV5IDxqYW1lcy5oYXJ0bGV5 QGltZ3RlYy5jb20+DQo+IA0KPiBBIGJyaWVmIGNvbW1pdCBtZXNzYWdlIGRlc2NyaWJpbmcgdGhl IGhhcmR3YXJlIGFuZCB3aGVyZSBpdCdzIGZvdW5kIHdvdWxkDQo+IGJlIG5pY2UuDQo+IA0KPiA+ IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY3J5cHRvL2lt Zy1oYXNoLnR4dA0KPiA+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2NyeXB0 by9pbWctaGFzaC50eHQNCj4gDQo+ID4gQEAgLTAsMCArMSwyOCBAQA0KPiA+ICsqIEltYWdpbmF0 aW9uIFRlY2hub2xvZ2llcyBMdGQuIEhhc2ggQWNjZWxlcmF0b3INCj4gPiArDQo+ID4gK1RoZSBo YXNoIGFjY2VsZXJhdG9yIHByb3ZpZGVzIGhhcmR3YXJlIGhhc2hpbmcgYWNjZWxlcmF0aW9uIGZv ciBTSEExLA0KPiA+ICtTSEEyMjQsIFNIQTI1NiBhbmQgTUQ1IGhhc2hlcw0KPiA+ICsNCj4gPiAr UmVxdWlyZWQgcHJvcGVydGllczoNCj4gPiArDQo+ID4gKy0gY29tcGF0aWJsZSA6ICJpbWcsaW1n LWhhc2gtYWNjZWxlcmF0b3ItcmV2MSINCj4gDQo+IEkga25vdyBJIG1lbnRpb25lZCBpbiB0aGUg aW50ZXJuYWwgcmV2aWV3IHRoYXQgaXQgd291bGQgYmUgZ29vZCB0byBoYXZlDQo+IHNvbWUgc29y dCBvZiB2ZXJzaW9uIGluZGljYXRvciwgYnV0IGl0IGxvb2tzIGxpa2UgZnJvbSB0aGUgVFJNIHRo YXQgdGhlIHZlcnNpb24NCj4gaXMgcHJvYmFibGUgKENSX0hBU0hfQ09SRV9SRVYpLiAgSWYgd2Ug ZXhwZWN0IHByb2JpbmcgZm9yIHRoZSByZXZpc2lvbg0KPiBudW1iZXIgdG8gYmUgc3VmZmljaWVu dCwgdGhlbiBwZXJoYXBzICJyZXYxIiBjYW4gYmUgZHJvcHBlZD8gIEFsc28sIHRoZQ0KPiBzZWNv bmQgImltZyIgaXMgcmVkdW5kYW50Lg0KDQpZZXMgdGhlIGNvcmUgSUQgYW5kIHZlcnNpb25zIGFy ZSBhdmFpbGFibGUsIHNvIEknbGwgZHJvcCByZXYtMSwgYW5kIHJlbW92ZSB0aGUgc2Vjb25kIGlt Zy4NCg0KPiANCj4gPiArLSByZWcgOiBPZmZzZXQgYW5kIGxlbmd0aCBvZiB0aGUgcmVnaXN0ZXIg c2V0IGZvciB0aGUgbW9kdWxlLCBhbmQgdGhlDQo+ID4gK0RNQSBwb3J0DQo+ID4gKy0gaW50ZXJy dXB0cyA6IFRoZSBkZXNpZ25hdGVkIElSUSBsaW5lIGZvciB0aGUgaGFzaGluZyBtb2R1bGUuDQo+ ID4gKy0gZG1hcyA6IERNQSBzcGVjaWZpZXIgYXMgcGVyDQo+ID4gK0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9kbWEvZG1hLnR4dA0KPiA+ICstIGRtYS1uYW1lcyA6IFNob3VsZCBi ZSAidHgiDQo+ID4gKy0gYnVzLWFkZHIgOiBUaGUgYnVzIGFkZHJlc3MgZm9yIHRoZSBpbnB1dCBk YXRhIGZvciBoYXNoaW5nIGJsb2NrDQo+IA0KPiBJIHRoaW5rIHRoaXMgY2FuIGJlIGRyb3BwZWQu ICBUaGlzIGlzIHRoZSBzYW1lIGFzIHRoZSBzZWNvbmQgInJlZyINCj4gZW50cnkgYWJvdmUsIGlz IGl0IG5vdD8NCg0KWWVzLCB0aGF0IHNob3VsZCBub3QgaGF2ZSBtYWRlIGl0IHRocm91Z2ggdG8g dGhlIHBhdGNoIC0gaXQgd2lsbCBiZSByZW1vdmVkLg0KDQpUaGFua3MsDQpKYW1lcy4NCg0K -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/crypto/img-hash.txt b/Documentation/devicetree/bindings/crypto/img-hash.txt new file mode 100644 index 0000000..94d789c --- /dev/null +++ b/Documentation/devicetree/bindings/crypto/img-hash.txt @@ -0,0 +1,28 @@ +* Imagination Technologies Ltd. Hash Accelerator + +The hash accelerator provides hardware hashing acceleration for +SHA1, SHA224, SHA256 and MD5 hashes + +Required properties: + +- compatible : "img,img-hash-accelerator-rev1" +- reg : Offset and length of the register set for the module, and the DMA port +- interrupts : The designated IRQ line for the hashing module. +- dmas : DMA specifier as per Documentation/devicetree/bindings/dma/dma.txt +- dma-names : Should be "tx" +- bus-addr : The bus address for the input data for hashing block +- clocks : Clock specifier +- clock-names : "hash_clk" Used to clock data through the accelerator + +Example: + + hash: hash@18149600 { + compatible = "img,img-hash-accelerator-rev1"; + reg = <0x18149600 0x100, 0x18101100 0x4>; + interrupts = <59 4 2>; + dmas = <&dma 8 0xffffffff>; + dma-names = "tx"; + bus-addr = <0x18101100>; + clocks = <&hash_clk>; + clock-names = "hash_clk"; + };
Signed-off-by: James Hartley <james.hartley@imgtec.com> --- .../devicetree/bindings/crypto/img-hash.txt | 28 ++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/crypto/img-hash.txt