diff mbox

ASoC: mxs: mxs-saif: Register the irq with the device name

Message ID 1415648970-14383-1-git-send-email-festevam@gmail.com (mailing list archive)
State Accepted
Commit 8c2727f97b4825adaad43bf98632abc9940345a4
Headers show

Commit Message

Fabio Estevam Nov. 10, 2014, 7:49 p.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

Instead of registering the irq name with the driver name, it's better to pass
the device name so that we have a more explicit indication as to what saif
instance the irq is related:

$ cat /proc/interrupts 
           CPU0       
...
214:          4         -  59  80042000.saif
215:          0         -  58  80046000.saif

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 sound/soc/mxs/mxs-saif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Nov. 10, 2014, 7:58 p.m. UTC | #1 
On Mon, Nov 10, 2014 at 05:49:30PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Instead of registering the irq name with the driver name, it's better to pass
> the device name so that we have a more explicit indication as to what saif
> instance the irq is related:

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c
index eade2742..d986508 100644
--- a/sound/soc/mxs/mxs-saif.c
+++ b/sound/soc/mxs/mxs-saif.c
@@ -773,7 +773,7 @@  static int mxs_saif_probe(struct platform_device *pdev)
 
 	saif->dev = &pdev->dev;
 	ret = devm_request_irq(&pdev->dev, saif->irq, mxs_saif_irq, 0,
-			       "mxs-saif", saif);
+			       dev_name(&pdev->dev), saif);
 	if (ret) {
 		dev_err(&pdev->dev, "failed to request irq\n");
 		return ret;