From patchwork Fri Nov 21 19:50:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Ruprecht X-Patchwork-Id: 5357751 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id EA06D9F1E1 for ; Fri, 21 Nov 2014 19:51:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 15F8020107 for ; Fri, 21 Nov 2014 19:51:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A186200E6 for ; Fri, 21 Nov 2014 19:51:33 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XruEu-0006qh-AP; Fri, 21 Nov 2014 19:51:32 +0000 Received: from mail-wi0-f175.google.com ([209.85.212.175]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XruEq-00062I-8D for linux-rockchip@lists.infradead.org; Fri, 21 Nov 2014 19:51:29 +0000 Received: by mail-wi0-f175.google.com with SMTP id l15so289352wiw.14 for ; Fri, 21 Nov 2014 11:51:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ld8eqoTRg2DEKBoUzUgjkB3Xq2A8kaavCheUvwT0PRk=; b=nGzgR4I//Bw1xeyRDZd+dyuphJi4wBJcY9gx0M+MXUarIzPQ6qgdNbqs11ytsR7sHM v+AczZY15QDapJCyVAmPIt09IvpMqNZf5H644ivxAoS8CrwwtYsCq51umd0tYEx+EP7b NV8p8ulntyWM931IsotU3f0MvTldNmuwE/oLBpov101AGfvogQzTS8L1vwbgO3CPSVYV K+noeMU/hvnT+yhKhWT9IUKFbxsw/lt2ucqZOuAG/hE2SGmioYe1H4RA7Iz7iqsq4Q2T jNugCLmKjKxTxbJH7mqaA2lbPK5rxJ6kuuJPT7Nm7KNc0Rjh+1KnTfzrxKHdbqDcv6e8 0eDw== X-Gm-Message-State: ALoCoQlfHRAcebyBJKHnsMpN/KAKuzwCLrDYN5NvpFmMlU29XUkSqelGRSGQQJDyZwei/h/K6Cof X-Received: by 10.194.176.198 with SMTP id ck6mr10616562wjc.25.1416599466483; Fri, 21 Nov 2014 11:51:06 -0800 (PST) Received: from faui49t.informatik.uni-erlangen.de (faui49t.informatik.uni-erlangen.de. [131.188.42.17]) by mx.google.com with ESMTPSA id p8sm5385037wia.1.2014.11.21.11.51.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 21 Nov 2014 11:51:05 -0800 (PST) From: Andreas Ruprecht To: Heiko Stuebner Subject: [PATCH v2] ASoC: rockchip: i2s: Fix Kconfig for I2S device driver Date: Fri, 21 Nov 2014 20:50:46 +0100 Message-Id: <1416599446-32310-1-git-send-email-rupran@einserver.de> X-Mailer: git-send-email 1.9.1 In-Reply-To: <20141121185856.GJ3815@sirena.org.uk> References: <20141121185856.GJ3815@sirena.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141121_115128_511835_EFDA0F04 X-CRM114-Status: GOOD ( 10.87 ) X-Spam-Score: -0.7 (/) Cc: alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood , Jaroslav Kysela , linux-rockchip@lists.infradead.org, Mark Brown , Andreas Ruprecht , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently, CONFIG_SND_SOC_ROCKCHIP_I2S could also be selected without having CONFIG_SND_SOC_ROCKCHIP enabled. As this makes no sense, a Kconfig dependency is added to CONFIG_SND_SOC_ROCKCHIP_I2S. This will make the item visible only if CONFIG_SND_SOC_ROCKCHIP is enabled. Additionally, as the code connected to CONFIG_SND_SOC_ROCKCHIP_I2S depends on CONFIG_SND_SOC_GENERIC_DMAENGINE_PCM, the dependency is moved to reflect this more clearly. Signed-off-by: Andreas Ruprecht Reported-by: Jim Davis --- sound/soc/rockchip/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig index b1fc0ca..e181826 100644 --- a/sound/soc/rockchip/Kconfig +++ b/sound/soc/rockchip/Kconfig @@ -1,7 +1,6 @@ config SND_SOC_ROCKCHIP tristate "ASoC support for Rockchip" depends on COMPILE_TEST || ARCH_ROCKCHIP - select SND_SOC_GENERIC_DMAENGINE_PCM help Say Y or M if you want to add support for codecs attached to the Rockchip SoCs' Audio interfaces. You will also need to @@ -9,7 +8,8 @@ config SND_SOC_ROCKCHIP config SND_SOC_ROCKCHIP_I2S tristate "Rockchip I2S Device Driver" - depends on CLKDEV_LOOKUP + depends on CLKDEV_LOOKUP && SND_SOC_ROCKCHIP + select SND_SOC_GENERIC_DMAENGINE_PCM help Say Y or M if you want to add support for I2S driver for Rockchip I2S device. The device supports upto maximum of