[v2,1/2] mfd: dt-bindings: add the description about dvs gpio for rk808
diff mbox

Message ID 1418267802-13159-2-git-send-email-zyw@rock-chips.com
State New, archived
Headers show

Commit Message

Chris Zhong Dec. 11, 2014, 3:16 a.m. UTC
add the description about dvs1, dvs2, dvsok, and add the example.

Signed-off-by: Chris Zhong <zyw@rock-chips.com>

---

Changes in v2:
- increase description about dvs pins

 Documentation/devicetree/bindings/mfd/rk808.txt | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

Comments

Doug Anderson Dec. 11, 2014, 10:05 p.m. UTC | #1
Chris,

On Wed, Dec 10, 2014 at 7:16 PM, Chris Zhong <zyw@rock-chips.com> wrote:
> +- dvs-gpios:  buck1/2 can be controlled by gpio dvs, this is GPIO specifiers
> +  for 2 host gpio's used for dvs. The format of the gpio specifier depends in
> +  the gpio controller. If DVS GPIOs aren't present, voltage changes will happen
> +  without being very quickly with no slow ramp time.

Remove the words "without being"

I assume Mark would rather make that change himself instead of getting
a respin, so probably don't send out a new version unless other
changes are needed.

Reviewed-by: Doug Anderson <dianders@chromium.org>
Mark Brown Dec. 12, 2014, 1:06 p.m. UTC | #2
On Thu, Dec 11, 2014 at 02:05:24PM -0800, Doug Anderson wrote:

> I assume Mark would rather make that change himself instead of getting
> a respin, so probably don't send out a new version unless other
> changes are needed.

No, I wouldn't.  Please resend if this is important.

Patch
diff mbox

diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt
index 9e6e259..923cdca 100644
--- a/Documentation/devicetree/bindings/mfd/rk808.txt
+++ b/Documentation/devicetree/bindings/mfd/rk808.txt
@@ -24,6 +24,14 @@  Optional properties:
 - vcc10-supply: The input supply for LDO_REG6
 - vcc11-supply: The input supply for LDO_REG8
 - vcc12-supply: The input supply for SWITCH_REG2
+- dvs-gpios:  buck1/2 can be controlled by gpio dvs, this is GPIO specifiers
+  for 2 host gpio's used for dvs. The format of the gpio specifier depends in
+  the gpio controller. If DVS GPIOs aren't present, voltage changes will happen
+  without being very quickly with no slow ramp time.
+- dvsok-gpios: if we use dvs gpio to control buck1/2, this gpio will be pull
+  high, once RK808 completed the adjustment of voltage. If the DVSOK isn't
+  present, we'll just delay based on whatever is specified in the regulator
+  constraints.
 
 Regulators: All the regulators of RK808 to be instantiated shall be
 listed in a child node named 'regulators'. Each regulator is represented
@@ -55,7 +63,10 @@  Example:
 		interrupt-parent = <&gpio0>;
 		interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
 		pinctrl-names = "default";
-		pinctrl-0 = <&pmic_int>;
+		pinctrl-0 = <&pmic_int &dvs_ok &dvs_1 &dvs_2>;
+		dvsok-gpios = <&gpio7 9 GPIO_ACTIVE_HIGH>;
+		dvs-gpios = <&gpio7 11 GPIO_ACTIVE_HIGH>,
+			    <&gpio7 15 GPIO_ACTIVE_HIGH>;
 		reg = <0x1b>;
 		rockchip,system-power-controller;
 		wakeup-source;