| Message ID | 5497F4CD.4010301@jp.fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 2014-12-22 at 19:39 +0900, Satoru Takeuchi wrote: > Sorry, I forgot to add Signed-off-by line. > > --- > From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com> > > "notused" is not necessary. Set 1 to the first entry is enough. Hi Satoru, Actually, the struct is copied from the kernel header include/uapi/linux/btrfs.h. I think they should stay the same, so either change the kernel header in another path, or just keep them in old style. Thanks, Gui > Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com> > > --- > ioctl.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/ioctl.h b/ioctl.h > index 2c2c7c1..c377b96 100644 > --- a/ioctl.h > +++ b/ioctl.h > @@ -474,8 +474,7 @@ struct btrfs_ioctl_qgroup_create_args { > > /* Error codes as returned by the kernel */ > enum btrfs_err_code { > - notused, > - BTRFS_ERROR_DEV_RAID1_MIN_NOT_MET, > + BTRFS_ERROR_DEV_RAID1_MIN_NOT_MET = 1, > BTRFS_ERROR_DEV_RAID10_MIN_NOT_MET, > BTRFS_ERROR_DEV_RAID5_MIN_NOT_MET, > BTRFS_ERROR_DEV_RAID6_MIN_NOT_MET, > -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Gui, On 2014/12/23 10:59, Gui Hecheng wrote: > On Mon, 2014-12-22 at 19:39 +0900, Satoru Takeuchi wrote: >> Sorry, I forgot to add Signed-off-by line. >> >> --- >> From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com> >> >> "notused" is not necessary. Set 1 to the first entry is enough. > > Hi Satoru, > > Actually, the struct is copied from the kernel header > include/uapi/linux/btrfs.h. > I think they should stay the same, so either change the kernel header > in another path, or just keep them in old style. OK, I'll send also kernel patches soon. Thanks, Satoru > > Thanks, > Gui > >> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com> >> >> --- >> ioctl.h | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/ioctl.h b/ioctl.h >> index 2c2c7c1..c377b96 100644 >> --- a/ioctl.h >> +++ b/ioctl.h >> @@ -474,8 +474,7 @@ struct btrfs_ioctl_qgroup_create_args { >> >> /* Error codes as returned by the kernel */ >> enum btrfs_err_code { >> - notused, >> - BTRFS_ERROR_DEV_RAID1_MIN_NOT_MET, >> + BTRFS_ERROR_DEV_RAID1_MIN_NOT_MET = 1, >> BTRFS_ERROR_DEV_RAID10_MIN_NOT_MET, >> BTRFS_ERROR_DEV_RAID5_MIN_NOT_MET, >> BTRFS_ERROR_DEV_RAID6_MIN_NOT_MET, >> -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/ioctl.h b/ioctl.h index 2c2c7c1..c377b96 100644 --- a/ioctl.h +++ b/ioctl.h @@ -474,8 +474,7 @@ struct btrfs_ioctl_qgroup_create_args { /* Error codes as returned by the kernel */ enum btrfs_err_code { - notused, - BTRFS_ERROR_DEV_RAID1_MIN_NOT_MET, + BTRFS_ERROR_DEV_RAID1_MIN_NOT_MET = 1, BTRFS_ERROR_DEV_RAID10_MIN_NOT_MET, BTRFS_ERROR_DEV_RAID5_MIN_NOT_MET, BTRFS_ERROR_DEV_RAID6_MIN_NOT_MET,