[v2,4/8] irqchip: devicetree: document Conexant Digicolor irq binding
diff mbox

Message ID 3bdf8fa0bf971b4881024e72312c3c9d29298e79.1420744369.git.baruch@tkos.co.il
State New, archived
Headers show

Commit Message

Baruch Siach Jan. 8, 2015, 7:40 p.m. UTC
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt

Comments

Mark Rutland Jan. 9, 2015, 11:50 a.m. UTC | #1
On Thu, Jan 08, 2015 at 07:40:00PM +0000, Baruch Siach wrote:
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> new file mode 100644
> index 000000000000..fdf9a4c59bf3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> @@ -0,0 +1,20 @@
> +Conexant Digicolor Interrupt Controller
> +
> +Required properties:
> +
> +- compatible : should be "cnxt,cx92755-ic"

I didn't spot "cnxt" in
Documentation/devicetree/bindings/vendor-prefixes.txt in mainline, nor
did I spot it added as part of this series. Please add it, assuming a
patch doing so is not already queued elsewhere.

> +- reg : Specifies base physical address and size of the MISC area, that is
> +  where the interrupt controller registers are located

Is this area shared with other devices?

> +- interrupt-controller : Identifies the node as an interrupt controller
> +- #interrupt-cells : Specifies the number of cells needed to encode an
> +  interrupt source. The value shall be 1.

There is no configuration that can be applied to individual interrupt
lines (e.g. trigger type)?

Thanks,
Mark.

> +
> +Example:
> +
> +	intc: intc@f0000000 {
> +		compatible = "cnxt,cx92755-ic";
> +		interrupt-controller;
> +		#interrupt-cells = <1>;
> +		reg = <0xf0000000 0x1000>;
> +	};
> +
> -- 
> 2.1.4
> 
>
Sergei Shtylyov Jan. 9, 2015, 3:12 p.m. UTC | #2
Hello.

On 1/8/2015 10:40 PM, Baruch Siach wrote:

> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>   .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt

> diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> new file mode 100644
> index 000000000000..fdf9a4c59bf3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> @@ -0,0 +1,20 @@
> +Conexant Digicolor Interrupt Controller
> +
> +Required properties:
> +
> +- compatible : should be "cnxt,cx92755-ic"
> +- reg : Specifies base physical address and size of the MISC area, that is
> +  where the interrupt controller registers are located
> +- interrupt-controller : Identifies the node as an interrupt controller
> +- #interrupt-cells : Specifies the number of cells needed to encode an
> +  interrupt source. The value shall be 1.
> +
> +Example:
> +
> +	intc: intc@f0000000 {

    The node name should be "interrupt-controller@f0000000", according to the 
ePAPR standard, section 2.2.2.

[...]

WBR, Sergei
Baruch Siach Jan. 11, 2015, 11:21 a.m. UTC | #3
Hi Mark,

On Fri, Jan 09, 2015 at 11:50:14AM +0000, Mark Rutland wrote:
> On Thu, Jan 08, 2015 at 07:40:00PM +0000, Baruch Siach wrote:
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> >  .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> > new file mode 100644
> > index 000000000000..fdf9a4c59bf3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> > @@ -0,0 +1,20 @@
> > +Conexant Digicolor Interrupt Controller
> > +
> > +Required properties:
> > +
> > +- compatible : should be "cnxt,cx92755-ic"
> 
> I didn't spot "cnxt" in
> Documentation/devicetree/bindings/vendor-prefixes.txt in mainline, nor
> did I spot it added as part of this series. Please add it, assuming a
> patch doing so is not already queued elsewhere.

I sent a vendor-prefixes.txt update earlier as part of the UART driver series. 
Greg has it queued in the tty-testing branch of his tty tree 
(https://git.kernel.org/cgit/linux/kernel/git/gregkh/tty.git/commit/?h=tty-testing&id=48c738631753186e0ec7dd0079beffb3a6f4bb5c).

> > +- reg : Specifies base physical address and size of the MISC area, that is
> > +  where the interrupt controller registers are located
> 
> Is this area shared with other devices?

Yes. The interrupt controller uses just a small area in this registers space 
(offsets 0x40 - 0x80). This trouble is that I also need access to the system 
global UC_IRQ_CONTROL register (offset 0x3a4), to configure interrupts channel 
and routing (IRQ/FIQ). I wonder whether register access via syscon is better.

> > +- interrupt-controller : Identifies the node as an interrupt controller
> > +- #interrupt-cells : Specifies the number of cells needed to encode an
> > +  interrupt source. The value shall be 1.
> 
> There is no configuration that can be applied to individual interrupt
> lines (e.g. trigger type)?

No. There is none.

baruch
Baruch Siach Jan. 11, 2015, 11:29 a.m. UTC | #4
Hi Sergei,

On Fri, Jan 09, 2015 at 06:12:44PM +0300, Sergei Shtylyov wrote:
> On 1/8/2015 10:40 PM, Baruch Siach wrote:
> 
> >Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> >---
> >  .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> 
> >diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> >new file mode 100644
> >index 000000000000..fdf9a4c59bf3
> >--- /dev/null
> >+++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> >@@ -0,0 +1,20 @@
> >+Conexant Digicolor Interrupt Controller
> >+
> >+Required properties:
> >+
> >+- compatible : should be "cnxt,cx92755-ic"
> >+- reg : Specifies base physical address and size of the MISC area, that is
> >+  where the interrupt controller registers are located
> >+- interrupt-controller : Identifies the node as an interrupt controller
> >+- #interrupt-cells : Specifies the number of cells needed to encode an
> >+  interrupt source. The value shall be 1.
> >+
> >+Example:
> >+
> >+	intc: intc@f0000000 {
> 
>    The node name should be "interrupt-controller@f0000000", according to the
> ePAPR standard, section 2.2.2.

I'll change that in my next submission.

Thanks,
baruch

Patch
diff mbox

diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
new file mode 100644
index 000000000000..fdf9a4c59bf3
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
@@ -0,0 +1,20 @@ 
+Conexant Digicolor Interrupt Controller
+
+Required properties:
+
+- compatible : should be "cnxt,cx92755-ic"
+- reg : Specifies base physical address and size of the MISC area, that is
+  where the interrupt controller registers are located
+- interrupt-controller : Identifies the node as an interrupt controller
+- #interrupt-cells : Specifies the number of cells needed to encode an
+  interrupt source. The value shall be 1.
+
+Example:
+
+	intc: intc@f0000000 {
+		compatible = "cnxt,cx92755-ic";
+		interrupt-controller;
+		#interrupt-cells = <1>;
+		reg = <0xf0000000 0x1000>;
+	};
+