diff mbox

kconfig: use va_end to match corresponding va_start

Message ID 1421068706-3689-1-git-send-email-colin.king@canonical.com (mailing list archive)
State New, archived
Headers show

Commit Message

Colin King Jan. 12, 2015, 1:18 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Although on some systems va_end is a no-op, it is good practice
to use va_end, especially since the manual states:

"Each invocation of va_start() must be matched by a corresponding
invocation of va_end() in the same function."

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 scripts/kconfig/confdata.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Michal Marek Jan. 27, 2015, 3:59 p.m. UTC | #1 
On 2015-01-12 14:18, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Although on some systems va_end is a no-op, it is good practice
> to use va_end, especially since the manual states:
> 
> "Each invocation of va_start() must be matched by a corresponding
> invocation of va_end() in the same function."
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied to kbuild.git#kconfig, thanks.

Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index f88d90f..28df18d 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -59,6 +59,7 @@  static void conf_message(const char *fmt, ...)
 	va_start(ap, fmt);
 	if (conf_message_callback)
 		conf_message_callback(fmt, ap);
+	va_end(ap);
 }
 
 const char *conf_get_configname(void)