[PM,2/2] OMAP McSPI: spin_unlock_irq() missing
diff mbox

Message ID 1233832029-21614-2-git-send-email-Aaro.Koskinen@nokia.com
State Superseded
Delegated to: Kevin Hilman
Headers show

Commit Message

Koskinen, Aaro (Nokia - FI/Espoo) Feb. 5, 2009, 11:07 a.m. UTC
spin_unlock_irq() not called on failure path

Signed-off-by: Aaro Koskinen <Aaro.Koskinen@nokia.com>
---
 drivers/spi/omap2_mcspi.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Patch
diff mbox

diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
index 4d09777..56e91a4 100644
--- a/drivers/spi/omap2_mcspi.c
+++ b/drivers/spi/omap2_mcspi.c
@@ -751,7 +751,7 @@  static void omap2_mcspi_work(struct work_struct *work)
 	spin_lock_irq(&mcspi->lock);
 
 	if (omap2_mcspi_enable_clocks(mcspi))
-		return;
+		goto out;
 
 	/* We only enable one channel at a time -- the one whose message is
 	 * at the head of the queue -- although this controller would gladly
@@ -855,6 +855,7 @@  static void omap2_mcspi_work(struct work_struct *work)
 
 	omap2_mcspi_disable_clocks(mcspi);
 
+out:
 	spin_unlock_irq(&mcspi->lock);
 }