| Message ID | 20150120124310.ba1dd7a6454f65255c1ed713@freescale.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
Hi Kim, On 01/20/2015 08:43 PM, Kim Phillips wrote: > ICV check failures are part of normal operation; > leave user notification up to the higher levels, > as is done in s/w algorithm implementations. > Tested on P4080DS. Tested-by: Cristian Stoica <cristian.stoica@freescale.com> Thanks, Cristian S. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 21, 2015 at 10:57:32AM +0200, Cristian Stoica wrote: > Hi Kim, > > On 01/20/2015 08:43 PM, Kim Phillips wrote: > > ICV check failures are part of normal operation; > > leave user notification up to the higher levels, > > as is done in s/w algorithm implementations. > > > > Tested on P4080DS. > > Tested-by: Cristian Stoica <cristian.stoica@freescale.com> Applied.
diff --git a/drivers/crypto/caam/error.c b/drivers/crypto/caam/error.c index 66d73bf..33e41ea 100644 --- a/drivers/crypto/caam/error.c +++ b/drivers/crypto/caam/error.c @@ -151,10 +151,15 @@ static void report_ccb_status(struct device *jrdev, const u32 status, else snprintf(err_err_code, sizeof(err_err_code), "%02x", err_id); - dev_err(jrdev, "%08x: %s: %s %d: %s%s: %s%s\n", - status, error, idx_str, idx, - cha_str, cha_err_code, - err_str, err_err_code); + /* + * CCB ICV check failures are part of normal operation life; + * we leave the upper layers to do what they want with them. + */ + if (err_id != JRSTA_CCBERR_ERRID_ICVCHK) + dev_err(jrdev, "%08x: %s: %s %d: %s%s: %s%s\n", + status, error, idx_str, idx, + cha_str, cha_err_code, + err_str, err_err_code); } static void report_jump_status(struct device *jrdev, const u32 status,
ICV check failures are part of normal operation; leave user notification up to the higher levels, as is done in s/w algorithm implementations. Signed-off-by: Kim Phillips <kim.phillips@freescale.com> --- drivers/crypto/caam/error.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)