Subject: [OPW kernel] [PATCH] Staging: __alinged is preferred over __attribute__((alinged(size)))
diff mbox

Message ID 20150129133702.GA6178@localhost
State New, archived
Headers show

Commit Message

scarlet-erza Jan. 29, 2015, 1:37 p.m. UTC
This patch fixes the checkpatch.pl warning in the drivers/staging/emuxx_udc/emuxx_udc.h

WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))

Signed-off-by: scarlet-erza <navyasri.tech@gmail.com>
 ---
---
 drivers/staging/emxx_udc/emxx_udc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Julia Lawall Jan. 29, 2015, 1:50 p.m. UTC | #1
Hello,

Thanks for your patch, but the application period doesn't start until mid
February, expected February 17.  So that your patches don't get lost and
you get feedback in a timely manner, it would be better to hold off until
then.

However, for some quick feedback on your patch:

In the subject, "aligned" is consistently misspelled.  Also, for staging
the subject line should say which staging driver is concerned, because
they are all different.  So, probably Staging: emxx_udc:.  But you can use
git log --oneline filename to see what is the common subject line for this
kind of driver.

On Thu, 29 Jan 2015, scarlet-erza wrote:

> This patch fixes the checkpatch.pl warning in the drivers/staging/emuxx_udc/emuxx_udc.h

You don't need to mention the file name.

> WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
>
> Signed-off-by: scarlet-erza <navyasri.tech@gmail.com>

You need to use your real name, eg something that could be in your
passport or driver's license.  If this is not the name associated with
your email address, then you need to put a fake From: line at the
beginning of your message, with the same information as is shown in the
Signed-off-by: line.

>  ---
> ---

There are two occurrences of --- here.  Perhaps you added one and another
one was added for you.

The patch does apply fine :)

julia

>  drivers/staging/emxx_udc/emxx_udc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
> index ee1b80d..2ac216f 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.h
> +++ b/drivers/staging/emxx_udc/emxx_udc.h
> @@ -535,7 +535,7 @@ typedef struct _T_FC_REGS {
>
>  	u8 Reserved1200[0x1000-0x200];	/* Reserved */
>
> -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS;
> +} __aligned(32) T_FC_REGS, *PT_FC_REGS;
>
>
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
scarlet-erza Jan. 29, 2015, 2:03 p.m. UTC | #2
Hi,
Thanks Julia for the feedback.I'll work on it.This was my first patch so 
had some had some trouble getting the mailing style correct.So,can I work 
on patches till 17th and post them later?
Thank You
Navya

On Thursday, January 29, 2015 at 7:06:48 PM UTC+5:30, navya sri nizamkari 
wrote:
>
> This patch fixes the checkpatch.pl warning in the 
> drivers/staging/emuxx_udc/emuxx_udc.h 
>
> WARNING: __aligned(size) is preferred over __attribute__((aligned(size))) 
>
> Signed-off-by: scarlet-erza <navyasri.tech@gmail.com> 
>  --- 
> --- 
>  drivers/staging/emxx_udc/emxx_udc.h | 2 +- 
>  1 file changed, 1 insertion(+), 1 deletion(-) 
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h 
> b/drivers/staging/emxx_udc/emxx_udc.h 
> index ee1b80d..2ac216f 100644 
> --- a/drivers/staging/emxx_udc/emxx_udc.h 
> +++ b/drivers/staging/emxx_udc/emxx_udc.h 
> @@ -535,7 +535,7 @@ typedef struct _T_FC_REGS { 
>   
>          u8 Reserved1200[0x1000-0x200];        /* Reserved */ 
>   
> -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS; 
> +} __aligned(32) T_FC_REGS, *PT_FC_REGS; 
>   
>   
>   
> -- 
> 1.9.1 
>
>
Julia Lawall Jan. 29, 2015, 2:11 p.m. UTC | #3
On Thu, 29 Jan 2015, navya sri nizamkari wrote:

> Hi,
> Thanks Julia for the feedback.I'll work on it.This was my first patch so had
> some had some trouble getting the mailing style correct.So,can I work on
> patches till 17th and post them later?

The only issue that the code might change in the meantime.  So you can
work on patches now, but just check that they still apply when the
application period starts.

julia

> Thank You
> Navya
>
> On Thursday, January 29, 2015 at 7:06:48 PM UTC+5:30, navya sri nizamkari
> wrote:
>       This patch fixes the checkpatch.pl warning in the
>       drivers/staging/emuxx_udc/emuxx_udc.h
>
>       WARNING: __aligned(size) is preferred over
>       __attribute__((aligned(size)))
>
>       Signed-off-by: scarlet-erza <navyasri.tech@gmail.com>
>        ---
>       ---
>        drivers/staging/emxx_udc/emxx_udc.h | 2 +-
>        1 file changed, 1 insertion(+), 1 deletion(-)
>
>       diff --git a/drivers/staging/emxx_udc/emxx_udc.h
>       b/drivers/staging/emxx_udc/emxx_udc.h
>       index ee1b80d..2ac216f 100644
>       --- a/drivers/staging/emxx_udc/emxx_udc.h
>       +++ b/drivers/staging/emxx_udc/emxx_udc.h
>       @@ -535,7 +535,7 @@ typedef struct _T_FC_REGS {
>        
>                u8 Reserved1200[0x1000-0x200];        /* Reserved */
>        
>       -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS;
>       +} __aligned(32) T_FC_REGS, *PT_FC_REGS;
>        
>        
>        
>       --
>       1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
Julia Lawall Jan. 29, 2015, 2:58 p.m. UTC | #4
On Thu, 29 Jan 2015, navya sri nizamkari wrote:

> Hi,
> Thanks Julia for the feedback.I'll work on it.This was my first patch so had
> some had some trouble getting the mailing style correct.So,can I work on
> patches till 17th and post them later?

Another thing that you can do in the meantime is read the patches written
by others.  It can help to get used to the style, and will make getting
your patches accepted more efficient.

julia

> Thank You
> Navya
>
> On Thursday, January 29, 2015 at 7:06:48 PM UTC+5:30, navya sri nizamkari
> wrote:
>       This patch fixes the checkpatch.pl warning in the
>       drivers/staging/emuxx_udc/emuxx_udc.h
>
>       WARNING: __aligned(size) is preferred over
>       __attribute__((aligned(size)))
>
>       Signed-off-by: scarlet-erza <navyasri.tech@gmail.com>
>        ---
>       ---
>        drivers/staging/emxx_udc/emxx_udc.h | 2 +-
>        1 file changed, 1 insertion(+), 1 deletion(-)
>
>       diff --git a/drivers/staging/emxx_udc/emxx_udc.h
>       b/drivers/staging/emxx_udc/emxx_udc.h
>       index ee1b80d..2ac216f 100644
>       --- a/drivers/staging/emxx_udc/emxx_udc.h
>       +++ b/drivers/staging/emxx_udc/emxx_udc.h
>       @@ -535,7 +535,7 @@ typedef struct _T_FC_REGS {
>        
>                u8 Reserved1200[0x1000-0x200];        /* Reserved */
>        
>       -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS;
>       +} __aligned(32) T_FC_REGS, *PT_FC_REGS;
>        
>        
>        
>       --
>       1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
scarlet-erza Jan. 29, 2015, 4:17 p.m. UTC | #5
Thanks for your help.I'll read more patches to get better at submitting 
patches.
Navya 

On Thursday, January 29, 2015 at 7:06:48 PM UTC+5:30, navya sri nizamkari 
wrote:
>
> This patch fixes the checkpatch.pl warning in the 
> drivers/staging/emuxx_udc/emuxx_udc.h 
>
> WARNING: __aligned(size) is preferred over __attribute__((aligned(size))) 
>
> Signed-off-by: scarlet-erza <navyasri.tech@gmail.com> 
>  --- 
> --- 
>  drivers/staging/emxx_udc/emxx_udc.h | 2 +- 
>  1 file changed, 1 insertion(+), 1 deletion(-) 
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h 
> b/drivers/staging/emxx_udc/emxx_udc.h 
> index ee1b80d..2ac216f 100644 
> --- a/drivers/staging/emxx_udc/emxx_udc.h 
> +++ b/drivers/staging/emxx_udc/emxx_udc.h 
> @@ -535,7 +535,7 @@ typedef struct _T_FC_REGS { 
>   
>          u8 Reserved1200[0x1000-0x200];        /* Reserved */ 
>   
> -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS; 
> +} __aligned(32) T_FC_REGS, *PT_FC_REGS; 
>   
>   
>   
> -- 
> 1.9.1 
>
>

Patch
diff mbox

diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
index ee1b80d..2ac216f 100644
--- a/drivers/staging/emxx_udc/emxx_udc.h
+++ b/drivers/staging/emxx_udc/emxx_udc.h
@@ -535,7 +535,7 @@  typedef struct _T_FC_REGS {
 
 	u8 Reserved1200[0x1000-0x200];	/* Reserved */
 
-} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS;
+} __aligned(32) T_FC_REGS, *PT_FC_REGS;