diff mbox

[4/4] drm/i915: Announce support for framebuffer modifiers

Message ID 1423147315-23890-5-git-send-email-tvrtko.ursulin@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tvrtko Ursulin Feb. 5, 2015, 2:41 p.m. UTC 
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Let the DRM core know we can handle it.

v2: Change to boolean true. (Daniel Vetter)

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Shuang He Feb. 8, 2015, 6 a.m. UTC | #1 
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 5721
-------------------------------------Summary-------------------------------------
Platform          Delta          drm-intel-nightly          Series Applied
PNV                                  283/283              283/283
ILK              +1                 308/319              309/319
SNB              +23-1              319/346              341/346
IVB              +2                 376/384              378/384
BYT                                  296/296              296/296
HSW                 -1              425/428              424/428
BDW                                  318/333              318/333
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
 ILK  igt_kms_flip_vblank-vs-hang      TIMEOUT(1, M37)PASS(1, M37)      PASS(1, M37)
*SNB  igt_kms_flip_dpms-vs-vblank-race      DMESG_WARN(2, M35M22)      PASS(1, M22)
 SNB  igt_kms_flip_modeset-vs-vblank-race-interruptible      DMESG_WARN(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_kms_flip_single-buffer-flip-vs-dpms-off-vs-modeset-interruptible      DMESG_WARN(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_kms_mmio_vs_cs_flip_setcrtc_vs_cs_flip      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_kms_mmio_vs_cs_flip_setplane_vs_cs_flip      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
*SNB  igt_kms_plane_plane-panning-bottom-right-pipe-B-plane-2      PASS(2, M35M22)      TIMEOUT(1, M22)
 SNB  igt_kms_rotation_crc_primary-rotation      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_kms_rotation_crc_sprite-rotation      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_pm_rpm_cursor      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_pm_rpm_cursor-dpms      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_pm_rpm_dpms-mode-unset-non-lpsp      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_pm_rpm_dpms-non-lpsp      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_pm_rpm_drm-resources-equal      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_pm_rpm_fences      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_pm_rpm_fences-dpms      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_pm_rpm_gem-execbuf      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_pm_rpm_gem-mmap-cpu      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_pm_rpm_gem-mmap-gtt      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_pm_rpm_gem-pread      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
*SNB  igt_pm_rpm_i2c      FAIL(1, M22)NSPT(1, M35)      PASS(1, M22)
 SNB  igt_pm_rpm_modeset-non-lpsp      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_pm_rpm_modeset-non-lpsp-stress-no-wait      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_pm_rpm_pci-d3-state      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
 SNB  igt_pm_rpm_rte      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
*IVB  igt_gem_storedw_batches_loop_normal      DMESG_WARN(2, M34)      PASS(1, M34)
 IVB  igt_gem_storedw_batches_loop_secure-dispatch      DMESG_WARN(1, M34)PASS(1, M34)      PASS(1, M34)
*HSW  igt_gem_storedw_loop_blt      PASS(2, M40M20)      DMESG_WARN(1, M20)
Note: You need to pay more attention to line start with '*'
Shuang He Feb. 8, 2015, 12:43 p.m. UTC | #2 
Hello, this one is invalid report when debugging smarter patch apply method, in which case, baseline has id bigger than this task will generate invalidate comparison result.
I have fixed the comparison algorithm.
A correct one will be sent out later

Thanks
	--Shuang

> -----Original Message-----
> From: He, Shuang
> Sent: Sunday, February 08, 2015 5:57 PM
> To: He, Shuang; Gao, Ethan; intel-gfx@lists.freedesktop.org;
> tvrtko.ursulin@linux.intel.com
> Subject: RE: [Intel-gfx] [PATCH 4/4] drm/i915: Announce support for
> framebuffer modifiers
> 
> Tested-By: PRC QA PRTS (Patch Regression Test System Contact:
> shuang.he@intel.com)
> Task id: 5721
> -------------------------------------Summary-------------------------------------
> Platform          Delta          drm-intel-nightly          Series
> Applied
> PNV                                  283/283
> 283/283
> ILK              +1                 308/319              309/319
> SNB              +23-1              319/346              341/346
> IVB              +2                 376/384              378/384
> BYT                                  296/296
> 296/296
> HSW                 -1              425/428              424/428
> BDW                                  318/333
> 318/333
> -------------------------------------Detailed-------------------------------------
> Platform  Test                                drm-intel-nightly
> Series Applied
>  ILK  igt_kms_flip_vblank-vs-hang      TIMEOUT(1, M37)PASS(1, M37)
> PASS(1, M37)
> *SNB  igt_kms_flip_dpms-vs-vblank-race      DMESG_WARN(2, M35M22)
> PASS(1, M22)
>  SNB  igt_kms_flip_modeset-vs-vblank-race-interruptible
> DMESG_WARN(1, M35)PASS(1, M22)      PASS(1, M22)
>  SNB  igt_kms_flip_single-buffer-flip-vs-dpms-off-vs-modeset-interruptible
> DMESG_WARN(1, M35)PASS(1, M22)      PASS(1, M22)
>  SNB  igt_kms_mmio_vs_cs_flip_setcrtc_vs_cs_flip      NSPT(1,
> M35)PASS(1, M22)      PASS(1, M22)
>  SNB  igt_kms_mmio_vs_cs_flip_setplane_vs_cs_flip      NSPT(1,
> M35)PASS(1, M22)      PASS(1, M22)
> *SNB  igt_kms_plane_plane-panning-bottom-right-pipe-B-plane-2
> PASS(2, M35M22)      TIMEOUT(1, M22)
>  SNB  igt_kms_rotation_crc_primary-rotation      NSPT(1, M35)PASS(1,
> M22)      PASS(1, M22)
>  SNB  igt_kms_rotation_crc_sprite-rotation      NSPT(1, M35)PASS(1, M22)
> PASS(1, M22)
>  SNB  igt_pm_rpm_cursor      NSPT(1, M35)PASS(1, M22)      PASS(1,
> M22)
>  SNB  igt_pm_rpm_cursor-dpms      NSPT(1, M35)PASS(1, M22)
> PASS(1, M22)
>  SNB  igt_pm_rpm_dpms-mode-unset-non-lpsp      NSPT(1, M35)PASS(1,
> M22)      PASS(1, M22)
>  SNB  igt_pm_rpm_dpms-non-lpsp      NSPT(1, M35)PASS(1, M22)
> PASS(1, M22)
>  SNB  igt_pm_rpm_drm-resources-equal      NSPT(1, M35)PASS(1, M22)
> PASS(1, M22)
>  SNB  igt_pm_rpm_fences      NSPT(1, M35)PASS(1, M22)      PASS(1,
> M22)
>  SNB  igt_pm_rpm_fences-dpms      NSPT(1, M35)PASS(1, M22)
> PASS(1, M22)
>  SNB  igt_pm_rpm_gem-execbuf      NSPT(1, M35)PASS(1, M22)
> PASS(1, M22)
>  SNB  igt_pm_rpm_gem-mmap-cpu      NSPT(1, M35)PASS(1, M22)
> PASS(1, M22)
>  SNB  igt_pm_rpm_gem-mmap-gtt      NSPT(1, M35)PASS(1, M22)
> PASS(1, M22)
>  SNB  igt_pm_rpm_gem-pread      NSPT(1, M35)PASS(1, M22)
> PASS(1, M22)
> *SNB  igt_pm_rpm_i2c      FAIL(1, M22)NSPT(1, M35)      PASS(1, M22)
>  SNB  igt_pm_rpm_modeset-non-lpsp      NSPT(1, M35)PASS(1, M22)
> PASS(1, M22)
>  SNB  igt_pm_rpm_modeset-non-lpsp-stress-no-wait      NSPT(1,
> M35)PASS(1, M22)      PASS(1, M22)
>  SNB  igt_pm_rpm_pci-d3-state      NSPT(1, M35)PASS(1, M22)
> PASS(1, M22)
>  SNB  igt_pm_rpm_rte      NSPT(1, M35)PASS(1, M22)      PASS(1, M22)
> *IVB  igt_gem_storedw_batches_loop_normal      DMESG_WARN(2, M34)
> PASS(1, M34)
>  IVB  igt_gem_storedw_batches_loop_secure-dispatch
> DMESG_WARN(1, M34)PASS(1, M34)      PASS(1, M34)
> *HSW  igt_gem_storedw_loop_blt      PASS(2, M40M20)
> DMESG_WARN(1, M20)
> Note: You need to pay more attention to line start with '*'
Shuang He Feb. 8, 2015, 12:44 p.m. UTC | #3 
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 5721
-------------------------------------Summary-------------------------------------
Platform          Delta          drm-intel-nightly          Series Applied
PNV                                  283/283              283/283
ILK                                  309/319              309/319
SNB              +1-2              342/346              341/346
IVB              +1-1              378/384              378/384
BYT                                  296/296              296/296
HSW              +1                 423/428              424/428
BDW                                  318/333              318/333
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
*SNB  igt_kms_flip_dpms-vs-vblank-race-interruptible      PASS(1, M22)      DMESG_WARN(1, M22)
 SNB  igt_kms_pipe_crc_basic_read-crc-pipe-A      DMESG_WARN(1, M22)PASS(1, M22)      PASS(1, M22)
*SNB  igt_kms_plane_plane-panning-bottom-right-pipe-B-plane-2      PASS(1, M22)      TIMEOUT(1, M22)
*IVB  igt_gem_pwrite_pread_snooped-copy-performance      PASS(1, M34)      DMESG_WARN(1, M34)
*IVB  igt_gem_storedw_batches_loop_normal      DMESG_WARN(1, M34)      PASS(1, M34)
*HSW  igt_gem_storedw_loop_vebox      DMESG_WARN(2, M20)      PASS(1, M20)
Note: You need to pay more attention to line start with '*'
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index cf64e3c..39a17f2 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -13234,6 +13234,8 @@  void intel_modeset_init(struct drm_device *dev)
 	dev->mode_config.preferred_depth = 24;
 	dev->mode_config.prefer_shadow = 1;
 
+	dev->mode_config.allow_fb_modifiers = true;
+
 	dev->mode_config.funcs = &intel_mode_funcs;
 
 	intel_init_quirks(dev);