[OPW,kernel] Staging: rtl8712: fix space coding style issue
diff mbox

Message ID 1423226222-4606-1-git-send-email-hamohammed.sa@gmail.com
State New, archived
Headers show

Commit Message

Haneen Mohammed Feb. 6, 2015, 12:37 p.m. UTC
Patch to the rtl8712_cmd.h file for the following checkpatch.pl error:
ERROR: space prohibited before that ',' (ctx:WxW)

Signed-off-by: haneen <hamohammed.sa@gmail.com>
---
 drivers/staging/rtl8712/rtl8712_cmd.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Julia Lawall Feb. 6, 2015, 5:54 p.m. UTC | #1
On Fri, 6 Feb 2015, haneen wrote:

> Patch to the rtl8712_cmd.h file for the following checkpatch.pl error:
> ERROR: space prohibited before that ',' (ctx:WxW)
>
> Signed-off-by: haneen <hamohammed.sa@gmail.com>

The name needs to be your full name, as you would have in your passport.
The name also needs to match the name in the From line.

Also, it would be good to hold off on sending patches until the start of
the application period, on February 17.  If you send patches now, they may
get overlooked.

julia

> ---
>  drivers/staging/rtl8712/rtl8712_cmd.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_cmd.h b/drivers/staging/rtl8712/rtl8712_cmd.h
> index 039ab3e..67e9e91 100644
> --- a/drivers/staging/rtl8712/rtl8712_cmd.h
> +++ b/drivers/staging/rtl8712/rtl8712_cmd.h
> @@ -109,16 +109,16 @@ enum rtl8712_h2c_cmd {
>  	GEN_CMD_CODE(_DisconnectCtrlEx), /*61*/
>
>  	/* To do, modify these h2c cmd, add or delete */
> -	GEN_CMD_CODE(_GetH2cLbk) ,
> +	GEN_CMD_CODE(_GetH2cLbk),
>
>  	/* WPS extra IE */
> -	GEN_CMD_CODE(_SetProbeReqExtraIE) ,
> -	GEN_CMD_CODE(_SetAssocReqExtraIE) ,
> -	GEN_CMD_CODE(_SetProbeRspExtraIE) ,
> -	GEN_CMD_CODE(_SetAssocRspExtraIE) ,
> +	GEN_CMD_CODE(_SetProbeReqExtraIE),
> +	GEN_CMD_CODE(_SetAssocReqExtraIE),
> +	GEN_CMD_CODE(_SetProbeRspExtraIE),
> +	GEN_CMD_CODE(_SetAssocRspExtraIE),
>
>  	/* the following is driver will do */
> -	GEN_CMD_CODE(_GetCurDataRate) ,
> +	GEN_CMD_CODE(_GetCurDataRate),
>
>  	GEN_CMD_CODE(_GetTxRetrycnt),  /* to record times that Tx retry to
>  					* transmit packet after association
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Haneen Mohammed Feb. 6, 2015, 8:40 p.m. UTC | #2
Noted thanks. For this should I resend the patch in a new thread?


On Friday, February 6, 2015 at 8:54:47 PM UTC+3, Julia Lawall wrote:
>
> On Fri, 6 Feb 2015, haneen wrote: 
>
> > Patch to the rtl8712_cmd.h file for the following checkpatch.pl error: 
> > ERROR: space prohibited before that ',' (ctx:WxW) 
> > 
> > Signed-off-by: haneen <hamoha...@gmail.com <javascript:>> 
>
> The name needs to be your full name, as you would have in your passport. 
> The name also needs to match the name in the From line. 
>
> Also, it would be good to hold off on sending patches until the start of 
> the application period, on February 17.  If you send patches now, they may 
> get overlooked. 
>
> julia 
>
> > --- 
> >  drivers/staging/rtl8712/rtl8712_cmd.h | 12 ++++++------ 
> >  1 file changed, 6 insertions(+), 6 deletions(-) 
> > 
> > diff --git a/drivers/staging/rtl8712/rtl8712_cmd.h 
> b/drivers/staging/rtl8712/rtl8712_cmd.h 
> > index 039ab3e..67e9e91 100644 
> > --- a/drivers/staging/rtl8712/rtl8712_cmd.h 
> > +++ b/drivers/staging/rtl8712/rtl8712_cmd.h 
> > @@ -109,16 +109,16 @@ enum rtl8712_h2c_cmd { 
> >          GEN_CMD_CODE(_DisconnectCtrlEx), /*61*/ 
> > 
> >          /* To do, modify these h2c cmd, add or delete */ 
> > -        GEN_CMD_CODE(_GetH2cLbk) , 
> > +        GEN_CMD_CODE(_GetH2cLbk), 
> > 
> >          /* WPS extra IE */ 
> > -        GEN_CMD_CODE(_SetProbeReqExtraIE) , 
> > -        GEN_CMD_CODE(_SetAssocReqExtraIE) , 
> > -        GEN_CMD_CODE(_SetProbeRspExtraIE) , 
> > -        GEN_CMD_CODE(_SetAssocRspExtraIE) , 
> > +        GEN_CMD_CODE(_SetProbeReqExtraIE), 
> > +        GEN_CMD_CODE(_SetAssocReqExtraIE), 
> > +        GEN_CMD_CODE(_SetProbeRspExtraIE), 
> > +        GEN_CMD_CODE(_SetAssocRspExtraIE), 
> > 
> >          /* the following is driver will do */ 
> > -        GEN_CMD_CODE(_GetCurDataRate) , 
> > +        GEN_CMD_CODE(_GetCurDataRate), 
> > 
> >          GEN_CMD_CODE(_GetTxRetrycnt),  /* to record times that Tx retry 
> to 
> >                                          * transmit packet after 
> association 
> > -- 
> > 1.9.1 
> > 
> > -- 
> > You received this message because you are subscribed to the Google 
> Groups "opw-kernel" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to opw-kernel+...@googlegroups.com <javascript:>. 
> > For more options, visit https://groups.google.com/d/optout. 
> > 
>
Julia Lawall Feb. 6, 2015, 8:57 p.m. UTC | #3
On Fri, 6 Feb 2015, Haneen Mohammed wrote:

> Noted thanks. For this should I resend the patch in a new thread?

I think that it would be ok to send it as v2 of your previous patch.

But wait until the application period starts.

julia

> 
> 
> On Friday, February 6, 2015 at 8:54:47 PM UTC+3, Julia Lawall wrote:
>       On Fri, 6 Feb 2015, haneen wrote:
> 
>       > Patch to the rtl8712_cmd.h file for the following
>       checkpatch.pl error:
>       > ERROR: space prohibited before that ',' (ctx:WxW)
>       >
>       > Signed-off-by: haneen <hamoha...@gmail.com>
> 
>       The name needs to be your full name, as you would have in your
>       passport.
>       The name also needs to match the name in the From line.
> 
>       Also, it would be good to hold off on sending patches until the
>       start of
>       the application period, on February 17.  If you send patches
>       now, they may
>       get overlooked.
> 
>       julia
> 
>       > ---
>       >  drivers/staging/rtl8712/rtl8712_cmd.h | 12 ++++++------
>       >  1 file changed, 6 insertions(+), 6 deletions(-)
>       >
>       > diff --git a/drivers/staging/rtl8712/rtl8712_cmd.h
>       b/drivers/staging/rtl8712/rtl8712_cmd.h
>       > index 039ab3e..67e9e91 100644
>       > --- a/drivers/staging/rtl8712/rtl8712_cmd.h
>       > +++ b/drivers/staging/rtl8712/rtl8712_cmd.h
>       > @@ -109,16 +109,16 @@ enum rtl8712_h2c_cmd {
>       >          GEN_CMD_CODE(_DisconnectCtrlEx), /*61*/
>       >
>       >          /* To do, modify these h2c cmd, add or delete */
>       > -        GEN_CMD_CODE(_GetH2cLbk) ,
>       > +        GEN_CMD_CODE(_GetH2cLbk),
>       >
>       >          /* WPS extra IE */
>       > -        GEN_CMD_CODE(_SetProbeReqExtraIE) ,
>       > -        GEN_CMD_CODE(_SetAssocReqExtraIE) ,
>       > -        GEN_CMD_CODE(_SetProbeRspExtraIE) ,
>       > -        GEN_CMD_CODE(_SetAssocRspExtraIE) ,
>       > +        GEN_CMD_CODE(_SetProbeReqExtraIE),
>       > +        GEN_CMD_CODE(_SetAssocReqExtraIE),
>       > +        GEN_CMD_CODE(_SetProbeRspExtraIE),
>       > +        GEN_CMD_CODE(_SetAssocRspExtraIE),
>       >
>       >          /* the following is driver will do */
>       > -        GEN_CMD_CODE(_GetCurDataRate) ,
>       > +        GEN_CMD_CODE(_GetCurDataRate),
>       >
>       >          GEN_CMD_CODE(_GetTxRetrycnt),  /* to record times
>       that Tx retry to
>       >                                          * transmit packet
>       after association
>       > --
>       > 1.9.1
>       >
>       > --
>       > You received this message because you are subscribed to the
>       Google Groups "opw-kernel" group.
>       > To unsubscribe from this group and stop receiving emails from
>       it, send an email to opw-kernel+...@googlegroups.com.
>       > For more options, visit https://groups.google.com/d/optout.
>       >
> 
> --
> You received this message because you are subscribed to the Google Groups
> "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
> 
>

Patch
diff mbox

diff --git a/drivers/staging/rtl8712/rtl8712_cmd.h b/drivers/staging/rtl8712/rtl8712_cmd.h
index 039ab3e..67e9e91 100644
--- a/drivers/staging/rtl8712/rtl8712_cmd.h
+++ b/drivers/staging/rtl8712/rtl8712_cmd.h
@@ -109,16 +109,16 @@  enum rtl8712_h2c_cmd {
 	GEN_CMD_CODE(_DisconnectCtrlEx), /*61*/
 
 	/* To do, modify these h2c cmd, add or delete */
-	GEN_CMD_CODE(_GetH2cLbk) ,
+	GEN_CMD_CODE(_GetH2cLbk),
 
 	/* WPS extra IE */
-	GEN_CMD_CODE(_SetProbeReqExtraIE) ,
-	GEN_CMD_CODE(_SetAssocReqExtraIE) ,
-	GEN_CMD_CODE(_SetProbeRspExtraIE) ,
-	GEN_CMD_CODE(_SetAssocRspExtraIE) ,
+	GEN_CMD_CODE(_SetProbeReqExtraIE),
+	GEN_CMD_CODE(_SetAssocReqExtraIE),
+	GEN_CMD_CODE(_SetProbeRspExtraIE),
+	GEN_CMD_CODE(_SetAssocRspExtraIE),
 
 	/* the following is driver will do */
-	GEN_CMD_CODE(_GetCurDataRate) ,
+	GEN_CMD_CODE(_GetCurDataRate),
 
 	GEN_CMD_CODE(_GetTxRetrycnt),  /* to record times that Tx retry to
 					* transmit packet after association