diff mbox

[v3,2/2] f2fs: enable fast symlink by utilizing inline data

Message ID 1427163628-3840-2-git-send-email-wanpeng.li@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wanpeng Li March 24, 2015, 2:20 a.m. UTC
Fast symlink can utilize inline data flow to avoid using any
i_addr region, since we need to handle many cases such as
truncation, roll-forward recovery, and fsck/dump tools.

Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
---
 fs/f2fs/inline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wanpeng Li March 24, 2015, 7:41 a.m. UTC | #1
Ping this one.
On Tue, Mar 24, 2015 at 10:20:28AM +0800, Wanpeng Li wrote:
>Fast symlink can utilize inline data flow to avoid using any
>i_addr region, since we need to handle many cases such as
>truncation, roll-forward recovery, and fsck/dump tools.
>
>Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
>---
> fs/f2fs/inline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
>index d3e0599..375d2c7 100644
>--- a/fs/f2fs/inline.c
>+++ b/fs/f2fs/inline.c
>@@ -21,7 +21,7 @@ bool f2fs_may_inline(struct inode *inode)
> 	if (f2fs_is_atomic_file(inode))
> 		return false;
> 
>-	if (!S_ISREG(inode->i_mode))
>+	if (!S_ISREG(inode->i_mode) && !S_ISLNK(inode->i_mode))
> 		return false;
> 
> 	if (i_size_read(inode) > MAX_INLINE_DATA)
>-- 
>2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wanpeng Li March 24, 2015, 7:43 a.m. UTC | #2
Just see it merged, sorry for the noise.
On Tue, Mar 24, 2015 at 03:41:59PM +0800, Wanpeng Li wrote:
>Ping this one.
>On Tue, Mar 24, 2015 at 10:20:28AM +0800, Wanpeng Li wrote:
>>Fast symlink can utilize inline data flow to avoid using any
>>i_addr region, since we need to handle many cases such as
>>truncation, roll-forward recovery, and fsck/dump tools.
>>
>>Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
>>---
>> fs/f2fs/inline.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
>>index d3e0599..375d2c7 100644
>>--- a/fs/f2fs/inline.c
>>+++ b/fs/f2fs/inline.c
>>@@ -21,7 +21,7 @@ bool f2fs_may_inline(struct inode *inode)
>> 	if (f2fs_is_atomic_file(inode))
>> 		return false;
>> 
>>-	if (!S_ISREG(inode->i_mode))
>>+	if (!S_ISREG(inode->i_mode) && !S_ISLNK(inode->i_mode))
>> 		return false;
>> 
>> 	if (i_size_read(inode) > MAX_INLINE_DATA)
>>-- 
>>2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
index d3e0599..375d2c7 100644
--- a/fs/f2fs/inline.c
+++ b/fs/f2fs/inline.c
@@ -21,7 +21,7 @@  bool f2fs_may_inline(struct inode *inode)
 	if (f2fs_is_atomic_file(inode))
 		return false;
 
-	if (!S_ISREG(inode->i_mode))
+	if (!S_ISREG(inode->i_mode) && !S_ISLNK(inode->i_mode))
 		return false;
 
 	if (i_size_read(inode) > MAX_INLINE_DATA)