| Message ID | 1427266399-19124-1-git-send-email-rtatiya@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Mar 25, 2015 at 12:23:19PM +0530, rtatiya@codeaurora.org wrote: > From: Rupesh Tatiya <rtatiya@codeaurora.org> > > USB 2.01+ full-speed devices can have extended descriptor as well > and can support LPM. > > Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b We can't take patches with this in it, as it makes no sense in a kernel changelog :( -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2015-03-25 at 12:23 +0530, rtatiya@codeaurora.org wrote: > From: Rupesh Tatiya <rtatiya@codeaurora.org> > > USB 2.01+ full-speed devices can have extended descriptor as well > and can support LPM. Yes, they in theory can, but what happens if they are actually asked to do so? On how many devices have you tested this patch? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>> >> USB 2.01+ full-speed devices can have extended descriptor as well >> and can support LPM. > > Yes, they in theory can, but what happens if they are actually > asked to do so? On how many devices have you tested this patch? > I have tested this on Qualcomm USB controller, LPM works. LPM works with same controller with Microsoft Windows as well. I have looked through few Broadcom/CSR controllers, but could not find one that had USB version >= 2.01. Thanks, Rupesh -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> On Wed, Mar 25, 2015 at 12:23:19PM +0530, rtatiya@codeaurora.org wrote: >> From: Rupesh Tatiya <rtatiya@codeaurora.org> >> >> USB 2.01+ full-speed devices can have extended descriptor as well >> and can support LPM. >> >> Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b > > We can't take patches with this in it, as it makes no sense in a kernel > changelog :( > > Sorry this is my first time (I read as much as I can before sending patch but not enough I guess). Should I remove "From" line or rephrase commit message? Thanks, Rupesh -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Apr 08, 2015 at 11:27:40AM -0000, rtatiya@codeaurora.org wrote: > > On Wed, Mar 25, 2015 at 12:23:19PM +0530, rtatiya@codeaurora.org wrote: > >> From: Rupesh Tatiya <rtatiya@codeaurora.org> > >> > >> USB 2.01+ full-speed devices can have extended descriptor as well > >> and can support LPM. > >> > >> Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b > > > > We can't take patches with this in it, as it makes no sense in a kernel > > changelog :( > > > > > > Sorry this is my first time (I read as much as I can before sending patch > but not enough I guess). Should I remove "From" line or rephrase commit > message? From line is fine. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>> On Wed, Mar 25, 2015 at 12:23:19PM +0530, rtatiya@codeaurora.org wrote: >>> From: Rupesh Tatiya <rtatiya@codeaurora.org> >>> >>> USB 2.01+ full-speed devices can have extended descriptor as well >>> and can support LPM. >>> >>> Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b >> >> We can't take patches with this in it, as it makes no sense in a kernel >> changelog :( >> >> > > Sorry this is my first time (I read as much as I can before sending patch > but not enough I guess). Should I remove "From" line or rephrase commit > message? Rupesh, Just remove below line from commit message: >>> Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b > > Thanks, > Rupesh > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - Pramod
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 9ef2d2c..1ed7b5d 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -140,7 +140,7 @@ static int usb_device_supports_lpm(struct usb_device *udev) /* USB 2.1 (and greater) devices indicate LPM support through * their USB 2.0 Extended Capabilities BOS descriptor. */ - if (udev->speed == USB_SPEED_HIGH) { + if (udev->speed == USB_SPEED_HIGH || udev->speed == USB_SPEED_FULL) { if (udev->bos->ext_cap && (USB_LPM_SUPPORT & le32_to_cpu(udev->bos->ext_cap->bmAttributes)))