diff mbox

thermal: armada: Update Armada 380 thermal sensor coefficients

Message ID 1429117688-27100-1-git-send-email-gregory.clement@free-electrons.com (mailing list archive)
State Accepted
Delegated to: Eduardo Valentin
Headers show

Commit Message

Gregory CLEMENT April 15, 2015, 5:08 p.m. UTC
From: Nadav Haklai <nadavh@marvell.com>

Improve the Armada 380 thermal sensor accuracy by using updated formula.
The updated formula is:
Temperature[C degrees] = 0.4761 * tsen_vsen_out - 279.1

Signed-off-by: Nadav Haklai <nadavh@marvell.com>
Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: <stable@vger.kernel.org> #v3.16
---
 drivers/thermal/armada_thermal.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Gregory CLEMENT April 27, 2015, 7:40 a.m. UTC | #1
Hi Zhang, Eduardo,

On 15/04/2015 19:08, Gregory CLEMENT wrote:
> From: Nadav Haklai <nadavh@marvell.com>
> 
> Improve the Armada 380 thermal sensor accuracy by using updated formula.
> The updated formula is:
> Temperature[C degrees] = 0.4761 * tsen_vsen_out - 279.1
> 
> Signed-off-by: Nadav Haklai <nadavh@marvell.com>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Cc: <stable@vger.kernel.org> #v3.16

Any chance that this fix was merged in 4.1-rc ?

Thanks,

Gregory


> ---
>  drivers/thermal/armada_thermal.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
> index c2556cf5186b..01255fd65135 100644
> --- a/drivers/thermal/armada_thermal.c
> +++ b/drivers/thermal/armada_thermal.c
> @@ -224,9 +224,9 @@ static const struct armada_thermal_data armada380_data = {
>  	.is_valid_shift = 10,
>  	.temp_shift = 0,
>  	.temp_mask = 0x3ff,
> -	.coef_b = 1169498786UL,
> -	.coef_m = 2000000UL,
> -	.coef_div = 4289,
> +	.coef_b = 2931108200UL,
> +	.coef_m = 5000000UL,
> +	.coef_div = 10502,
>  	.inverted = true,
>  };
>  
>
Gregory CLEMENT May 6, 2015, 12:45 p.m. UTC | #2
Hi Zhang, Eduardo,

On 27/04/2015 09:40, Gregory CLEMENT wrote:
> Hi Zhang, Eduardo,
> 
> On 15/04/2015 19:08, Gregory CLEMENT wrote:
>> From: Nadav Haklai <nadavh@marvell.com>
>>
>> Improve the Armada 380 thermal sensor accuracy by using updated formula.
>> The updated formula is:
>> Temperature[C degrees] = 0.4761 * tsen_vsen_out - 279.1
>>
>> Signed-off-by: Nadav Haklai <nadavh@marvell.com>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> Cc: <stable@vger.kernel.org> #v3.16
> 
> Any chance that this fix was merged in 4.1-rc ?

I saw that you missed the merge window. However I think this patch is really
a fix and is a good candidate to be merged in 4.1.


Thanks,

Gregory


> 
> Thanks,
> 
> Gregory
> 
> 
>> ---
>>  drivers/thermal/armada_thermal.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
>> index c2556cf5186b..01255fd65135 100644
>> --- a/drivers/thermal/armada_thermal.c
>> +++ b/drivers/thermal/armada_thermal.c
>> @@ -224,9 +224,9 @@ static const struct armada_thermal_data armada380_data = {
>>  	.is_valid_shift = 10,
>>  	.temp_shift = 0,
>>  	.temp_mask = 0x3ff,
>> -	.coef_b = 1169498786UL,
>> -	.coef_m = 2000000UL,
>> -	.coef_div = 4289,
>> +	.coef_b = 2931108200UL,
>> +	.coef_m = 5000000UL,
>> +	.coef_div = 10502,
>>  	.inverted = true,
>>  };
>>  
>>
> 
>
diff mbox

Patch

diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
index c2556cf5186b..01255fd65135 100644
--- a/drivers/thermal/armada_thermal.c
+++ b/drivers/thermal/armada_thermal.c
@@ -224,9 +224,9 @@  static const struct armada_thermal_data armada380_data = {
 	.is_valid_shift = 10,
 	.temp_shift = 0,
 	.temp_mask = 0x3ff,
-	.coef_b = 1169498786UL,
-	.coef_m = 2000000UL,
-	.coef_div = 4289,
+	.coef_b = 2931108200UL,
+	.coef_m = 5000000UL,
+	.coef_div = 10502,
 	.inverted = true,
 };