nd: fix 'sh' arch is CONFIG_SUPERH
diff mbox

Message ID 20150420175938.39449.36567.stgit@dwillia2-desk3.amr.corp.intel.com
State Superseded
Headers show

Commit Message

Dan Williams April 20, 2015, 6 p.m. UTC
Paul says:
  "...noticed this patch contains the only Kconfig typo I know by heart.
  Because I think you meant to say:
          depends on (X86 || IA64 || ARM || ARM64 || SUPERH || XTENSA)"

Reported-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---

Thanks Paul!

 drivers/block/nd/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig April 20, 2015, 6:06 p.m. UTC | #1
On Mon, Apr 20, 2015 at 02:00:06PM -0400, Dan Williams wrote:
> Paul says:
>   "...noticed this patch contains the only Kconfig typo I know by heart.
>   Because I think you meant to say:
>           depends on (X86 || IA64 || ARM || ARM64 || SUPERH || XTENSA)"

This just shows how bogus this style of Kconfig dependency is.

Instead let each arch declare that is has the feature, either using a
def_bool in Kconfig or a #define in a header.
Dan Williams April 20, 2015, 6:18 p.m. UTC | #2
On Mon, Apr 20, 2015 at 11:06 AM, Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Apr 20, 2015 at 02:00:06PM -0400, Dan Williams wrote:
>> Paul says:
>>   "...noticed this patch contains the only Kconfig typo I know by heart.
>>   Because I think you meant to say:
>>           depends on (X86 || IA64 || ARM || ARM64 || SUPERH || XTENSA)"
>
> This just shows how bogus this style of Kconfig dependency is.
>
> Instead let each arch declare that is has the feature, either using a
> def_bool in Kconfig or a #define in a header.
>

Yeah, this was a stop-gap solution after 0day pointed out that
ioremap_cache() does not exist on all archs.  I'll take a look at
providing a generic fallback...

Patch
diff mbox

diff --git a/drivers/block/nd/Kconfig b/drivers/block/nd/Kconfig
index 72580cb0e39c..ba12776b44e7 100644
--- a/drivers/block/nd/Kconfig
+++ b/drivers/block/nd/Kconfig
@@ -1,5 +1,5 @@ 
 config ND_ARCH_HAS_IOREMAP_CACHE
-	depends on (X86 || IA64 || ARM || ARM64 || SH || XTENSA)
+	depends on (X86 || IA64 || ARM || ARM64 || SUPERH || XTENSA)
 	def_bool y
 
 menuconfig NFIT_DEVICES