[v3,1/5] ASoC: Correct typo in SOC_VALUE_ENUM_SINGLE macro
diff mbox

Message ID 1430480247-28753-1-git-send-email-ckeepax@opensource.wolfsonmicro.com
State New
Headers show

Commit Message

Charles Keepax May 1, 2015, 11:37 a.m. UTC
xnitmes is clearly intended to be xnitems, but all other macros just
refer to this as xitems, so change it to that.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---

Changes since v2:
 - Use snd_soc_enum_item_to_val to get zero value from mux to account for
   non-value enums
 - Improve handling in snd_soc_dapm_put_enum_double of the situation
   where the register and widget views of the control values don't match

Thanks,
Charles

 include/sound/soc.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Lars-Peter Clausen May 1, 2015, 2:31 p.m. UTC | #1
On 05/01/2015 01:37 PM, Charles Keepax wrote:
> xnitmes is clearly intended to be xnitems, but all other macros just
> refer to this as xitems, so change it to that.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Looks good, works fine, thanks. Patch 1-4:

Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Tested-by: Lars-Peter Clausen <lars@metafoo.de>
Mark Brown May 4, 2015, 12:03 p.m. UTC | #2
On Fri, May 01, 2015 at 12:37:23PM +0100, Charles Keepax wrote:

> Changes since v2:
>  - Use snd_soc_enum_item_to_val to get zero value from mux to account for
>    non-value enums
>  - Improve handling in snd_soc_dapm_put_enum_double of the situation
>    where the register and widget views of the control values don't match
> 
> Thanks,
> Charles
> 
>  include/sound/soc.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

This list of changes doesn't appear to have anything to do with this
patch?
Charles Keepax May 4, 2015, 2:23 p.m. UTC | #3
On Mon, May 04, 2015 at 01:03:41PM +0100, Mark Brown wrote:
> On Fri, May 01, 2015 at 12:37:23PM +0100, Charles Keepax wrote:
> 
> > Changes since v2:
> >  - Use snd_soc_enum_item_to_val to get zero value from mux to account for
> >    non-value enums
> >  - Improve handling in snd_soc_dapm_put_enum_double of the situation
> >    where the register and widget views of the control values don't match
> > 
> > Thanks,
> > Charles
> > 
> >  include/sound/soc.h |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> This list of changes doesn't appear to have anything to do with this
> patch?

Sorry, I probably should have either added a cover letter or put
those on patch 4 that is the patch they relate to.

Thanks,
Charles

Patch
diff mbox

diff --git a/include/sound/soc.h b/include/sound/soc.h
index a73d855..45cfd69 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -190,8 +190,8 @@ 
 #define SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, xitems, xtexts, xvalues) \
 {	.reg = xreg, .shift_l = xshift_l, .shift_r = xshift_r, \
 	.mask = xmask, .items = xitems, .texts = xtexts, .values = xvalues}
-#define SOC_VALUE_ENUM_SINGLE(xreg, xshift, xmask, xnitmes, xtexts, xvalues) \
-	SOC_VALUE_ENUM_DOUBLE(xreg, xshift, xshift, xmask, xnitmes, xtexts, xvalues)
+#define SOC_VALUE_ENUM_SINGLE(xreg, xshift, xmask, xitems, xtexts, xvalues) \
+	SOC_VALUE_ENUM_DOUBLE(xreg, xshift, xshift, xmask, xitems, xtexts, xvalues)
 #define SOC_ENUM_SINGLE_VIRT(xitems, xtexts) \
 	SOC_ENUM_SINGLE(SND_SOC_NOPM, 0, xitems, xtexts)
 #define SOC_ENUM(xname, xenum) \